Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manifest v3 #39

Open
wants to merge 43 commits into
base: legacy
Choose a base branch
from

Conversation

Lukas-Zenick
Copy link
Collaborator

@Lukas-Zenick Lukas-Zenick commented Aug 27, 2022

Manifest v3!


This change is Reviewable

Service worker is running properly
permissions and other manifest v3 basics updated
badge update works on startup
significant progress on getCurrentSemesters()
currently logs semesters
technically I haven't verified add works yet: double check that
More working now. The reason the plus button doesn't work is because the grades aren't set yet. Work on setting the grades into memory next
js/Template.js Outdated Show resolved Hide resolved
js/util.js Outdated Show resolved Hide resolved
js/util.js Outdated Show resolved Hide resolved
manifest.json Show resolved Hide resolved
@sghsri sghsri closed this Feb 2, 2024
@sghsri sghsri reopened this Apr 28, 2024
Copy link

Your pull request title did not conform to conventional commits standards. Our upcoming automated release pipeline will automatically determine
the proper release version based on your pull request title.
Cheat Sheet

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

1 similar comment
Copy link

Your pull request title did not conform to conventional commits standards. Our upcoming automated release pipeline will automatically determine
the proper release version based on your pull request title.
Cheat Sheet

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

@Razboy20 Razboy20 added wip blocked Do not merge (yet) labels May 19, 2024
@Razboy20 Razboy20 changed the base branch from main to legacy May 19, 2024 23:25
@doprz doprz self-requested a review May 27, 2024 21:54
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Let's wait until the LD-admin team reaches a decision regarding pushing one of these two PRs before the MV3 deadline:

  • migrating to MV3 v1.3.0.0
  • rc-build v2.0.0-rc

"name": "UT Registration Plus",
"version": "1.2.2.7",
"version": "1.3.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -1,17 +1,19 @@
{
"manifest_version": 2,
"manifest_version": 3,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@doprz doprz changed the title Manifest v3 feat: manifest v3 May 27, 2024
Copy link
Collaborator

@Samathingamajig Samathingamajig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, i think it works just as well as it did before the MV3 change

@DereC4
Copy link
Contributor

DereC4 commented May 30, 2024

Mr. Lukas and associated, after careful consideration I've decided to endorse your pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Do not merge (yet) wip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants