-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: manifest v3 #39
base: legacy
Are you sure you want to change the base?
feat: manifest v3 #39
Conversation
Service worker is running properly permissions and other manifest v3 basics updated badge update works on startup
significant progress on getCurrentSemesters() currently logs semesters
technically I haven't verified add works yet: double check that
More working now. The reason the plus button doesn't work is because the grades aren't set yet. Work on setting the grades into memory next
This reverts commit 40013fc.
FUCK YEAH
This reverts commit c85d258.
Bug where a class did not realize it could have more then one location if the time slots were at the same time on different days
Your pull request title did not conform to conventional commits standards. Our upcoming automated release pipeline will automatically determine
|
1 similar comment
Your pull request title did not conform to conventional commits standards. Our upcoming automated release pipeline will automatically determine
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Let's wait until the LD-admin team reaches a decision regarding pushing one of these two PRs before the MV3 deadline:
- migrating to MV3
v1.3.0.0
- rc-build
v2.0.0-rc
"name": "UT Registration Plus", | ||
"version": "1.2.2.7", | ||
"version": "1.3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -1,17 +1,19 @@ | |||
{ | |||
"manifest_version": 2, | |||
"manifest_version": 3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall, i think it works just as well as it did before the MV3 change
Mr. Lukas and associated, after careful consideration I've decided to endorse your pull request |
Manifest v3!
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)