Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust default security context based on deployment context #34

Merged
merged 2 commits into from
Jun 2, 2024
Merged

Adjust default security context based on deployment context #34

merged 2 commits into from
Jun 2, 2024

Conversation

MaikuMori
Copy link
Owner

@MaikuMori MaikuMori commented May 31, 2024 •
edited
Loading

Bump gotenberg minor version.

Descriptive description goes here.

Tasks:

  • I've made changes
  • I've bumped chart's version in Chart.yaml
  • I've added changes to charts CHANGELOG.md
  • I've run helm-docs

@MaikuMori MaikuMori mentioned this pull request May 31, 2024
Closed
4 tasks
@MaikuMori MaikuMori changed the title Adjust default values based on deployment context Adjust default security context based on deployment context May 31, 2024
jonasgeiler
jonasgeiler suggested changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@jonasgeiler jonasgeiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! It's a good alternative without all the licensing concerns. I would only suggest adding a bit more documentation.

charts/gotenberg/README.md Outdated Show resolved Hide resolved
charts/gotenberg/values.yaml Show resolved Hide resolved
@MaikuMori MaikuMori merged commit 4a56154 into master Jun 2, 2024
6 checks passed
@MaikuMori MaikuMori deleted the modify-security-context branch June 2, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasgeiler jonasgeiler jonasgeiler requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MaikuMori @jonasgeiler