Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to name Sentry Releases with versions #354

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

markhougaard
Copy link
Contributor

@markhougaard
Copy link
Contributor Author

@andreeaceachir142 Do you know which folder we generate source maps in? Would be great to set that as well: https://github.com/marketplace/actions/sentry-release#examples

@andreeaceachir142
Copy link
Contributor

@markhougaard from what I know, when creating a react app, the source maps are generated under the folder map-template/build/assets. They are the .map files under that folder.
I'm not 100& sure I'm correct here, so maybe @ammapspeople has some input too.

@ammapspeople
Copy link
Contributor

@markhougaard @andreeaceachir142

  • When building the React app for production, source map files are located alongside the distribution files in the build/assets folder.
  • When building for npm, source map files are also located alongside the distribution files in the dist folder.

So if we can set a relative folder for the source map, it should work.

@ammapspeople
Copy link
Contributor

@markhougaard @andreeaceachir142 What should happen here?

@andreeaceachir142
Copy link
Contributor

I think @markhougaard is planning to release this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants