-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create params for skipGo and accessibility #381
base: main
Are you sure you want to change the base?
Create params for skipGo and accessibility #381
Conversation
I will take care of read me and changelog later. I want to make sure that logic is correct @andreeaceachir142 |
} | ||
} | ||
}, [skipGo, isSet, directionsFromLocation, directionsToLocation, isDirectionReady]) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some docs on what is happening here
if (originLocation?.geometry && destinationLocation?.geometry) { | ||
directionsService.getRoute({ | ||
origin: getLocationPoint(originLocation), | ||
destination: getLocationPoint(destinationLocation), | ||
travelMode: travelMode, | ||
avoidStairs: accessibilityOn | ||
avoidStairs: accessibilityOn || accessibility[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use recoil value instead
What:
How:
true
, then we assign checked totrue
.onStartDirections
function which normally is called when we click 'Go' button.isFinishRouteState
atom, so when we click 'Finish Route', we are not ending up in infinite loop of rendering the route.Working solution:
Uploading Screen Recording 2024-06-20 at 11.22.55.mov…