feat: move unit tests from Circleci to Github actions #25570
+68
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25570 +/- ##
========================================
Coverage 69.60% 69.60%
========================================
Files 1364 1364
Lines 48173 48173
Branches 13291 13291
========================================
Hits 33527 33527
Misses 14646 14646 ☔ View full report in Codecov by Sentry. |
Builds ready [a399875]
Page Load Metrics (46 ± 3 ms)
Bundle size diffs
|
Builds ready [ce18831]
Page Load Metrics (225 ± 246 ms)
Bundle size diffs
|
|
Builds ready [9711df5]
Page Load Metrics (70 ± 11 ms)
Bundle size diffs
|
davidmurdoch
requested changes
Jul 2, 2024
| @@ -1462,7 +1449,7 @@ jobs: | |||
| fi | |||
| no_output_timeout: 5m | |||
| environment: | |||
| ENABLE_CONFIRMATION_REDESIGN: "true" | |||
There was a problem hiding this comment.
leave these drive-by changes out so we can git blame more usefully in the future.
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 'lts/*' |
There was a problem hiding this comment.
we probably need to pin the version, as not doing so will result in non-deterministic tests.
Comment on lines
+11
to
+25
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 'lts/*' | ||
|
|
||
| - run: corepack enable | ||
|
|
||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: yarn |
There was a problem hiding this comment.
why do we need two steps to set up Node?
Comment on lines
+41
to
+58
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 'lts/*' | ||
|
|
||
| - run: corepack enable | ||
|
|
||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: yarn | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn --immutable |
There was a problem hiding this comment.
Is there a way to make these steps, or at least some of them (especially the yarn --immutable step), part of the same workflow so we don't have to repeat work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves unit tests from Circleci to Github actions. This is needed to pass the Jest export to SonarCloud in order finalize the SonarCloud integration. The reason why we want to use Github action rather than Circleci is because Sonarcloud integration happens in a Github action and we cannot pass data (i.e. the artifact) from Circleci to Github action.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2449
Manual testing steps
Screenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist