Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove blockaid env variable #10215

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

chore: Remove blockaid env variable #10215

wants to merge 14 commits into from

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jul 2, 2024

Description

Remove bloackaid env var from mobile code.

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1629

Manual testing steps

  1. Remove blockaid env var from local
  2. Start mobile app
  3. Blockaid validations should work as before

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Jul 2, 2024
@jpuri jpuri requested review from a team as code owners July 2, 2024 14:03
Copy link
Contributor

github-actions bot commented Jul 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri marked this pull request as draft July 2, 2024 14:18
@jpuri jpuri marked this pull request as ready for review July 3, 2024 05:16
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 3, 2024
Copy link
Contributor

github-actions bot commented Jul 3, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 34b9cee
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a1d9dca2-5c57-4972-897e-72d26210e4e1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Jul 3, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.67%. Comparing base (ea14ef7) to head (34b9cee).
Report is 13 commits behind head on main.

Files Patch % Lines
app/components/UI/WhatsNewModal/whatsNewList.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10215      +/-   ##
==========================================
+ Coverage   49.50%   49.67%   +0.17%     
==========================================
  Files        1438     1444       +6     
  Lines       34674    34728      +54     
  Branches     3853     3852       -1     
==========================================
+ Hits        17166    17252      +86     
+ Misses      16426    16396      -30     
+ Partials     1082     1080       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 5, 2024
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants