Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ramp): upgrade sdk to 1.28.3 and remove chainId casting #10262

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore(ramp): upgrade sdk to 1.28.3 and remove chainId casting #10262

wants to merge 6 commits into from
+52 −167

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Jul 5, 2024 •
edited
Loading

Description

This PR upgrades Ramp SDK version to 1.28.3, it updates chainId mock data to be string and removes the casting of its type, finishing what was pending from #9652

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/RAMPS-1733

Manual testing steps

  1. Ramps Flows (Buy & Sell) must not be impacted.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added the team-ramp issues related to Ramp features label Jul 5, 2024
@wachunei wachunei added Run Smoke E2E Triggers smoke e2e on Bitrise needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-ramp-qa Tickets that need feature QA on the ramps flows labels Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 861c904
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7350ec7f-8bf6-4d0b-9089-0e1b1300bc02

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@consensys/[email protected] Transitive: unsafe +3 779 kB pmkowalski

🚮 Removed packages: npm/@consensys/[email protected]

View full report↗︎

@wachunei wachunei marked this pull request as ready for review July 9, 2024 15:36
@wachunei wachunei requested review from a team as code owners July 9, 2024 15:36
Cal-L
Cal-L reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

app/components/UI/Ramp/Views/NetworkSwitcher/NetworkSwitcher.test.tsx
@@ -66,7 +66,7 @@ const mockedNetworksDetails = [
},
];

function render(Component: React.ComponentType, chainId?: string) {
function render(Component: React.ComponentType, chainId?: `0x${string}`) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove chainId since it's never used

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used in line 83 and 367 of this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, what I meant was that there are no instances where chainId is passed into render and therefore is never used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one in line 367 https://github.com/MetaMask/metamask-mobile/pull/10262/files/861c904420ff6ee86d25de3311e14f4c1775eb88#diff-7819aaffe352000e97942bf6d71d96e08c2759a523cc7085ca4677b3f7f40992R367

app/components/UI/Ramp/Views/NetworkSwitcher/NetworkSwitcher.tsx Show resolved Hide resolved
app/components/UI/Ramp/utils/index.test.ts Outdated Show resolved Hide resolved
@wachunei wachunei requested a review from Cal-L July 10, 2024 18:13
@wachunei wachunei added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 11, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3f981d7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d230ac08-9081-4766-95fc-c06f59d33771

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
63.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Cal-L
Cal-L approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-ramp-qa Tickets that need feature QA on the ramps flows Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
PR review queue
Status: Review finalised - Ready to be merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wachunei @Cal-L