Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alert Body Prop #155

Merged
merged 2 commits into from
May 6, 2024
Merged

Add Alert Body Prop #155

merged 2 commits into from
May 6, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented May 5, 2024

Add new body prop to alert component, to support both existing simple text based body as well as alert components containing more advanced alert content.

Description

  • Added body prop to alert to support more advanced alert body scenarios
  • Added new stories and unit tests

Related Issue

N/A

Motivation and Context

  • The basic alert makes use of a paragraph to display alert text. Embedding anything but text within the body results in an invalid HTML combination, resulting in a console error. This addition provides a mechanism for both existing and new body alert scenarios.

How Has This Been Tested?

  • Local Testing

Screenshots (if appropriate):

Screenshot 2024-05-04 at 8 12 51 PM

@jbouder jbouder added the enhancement New feature or request label May 5, 2024
Copy link
Collaborator

@kildre kildre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment on the same id.

@jbouder jbouder merged commit 54a99b1 into main May 6, 2024
5 checks passed
@jbouder jbouder deleted the alert-body-fix branch May 6, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants