Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc component fixes #45

Merged
merged 3 commits into from
May 18, 2023
Merged

Misc component fixes #45

merged 3 commits into from
May 18, 2023

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented May 18, 2023

A few issues noted while making use of components in react app.

Description

  • Updated Card component to better support passing in a custom class
  • Fixed File Input component, preventing unnecessary component re-rendering

Related Issue

N/A

Motivation and Context

General component improvements and fixes

How Has This Been Tested?

Verified locally in storybook

Screenshots (if appropriate):

Screenshot 2023-05-18 at 9 08 59 AM

@jbouder jbouder added bug Something isn't working enhancement New feature or request labels May 18, 2023
bapplejax
bapplejax approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@bapplejax bapplejax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jbouder jbouder merged commit 72c6ca2 into main May 18, 2023
5 checks passed
@jbouder jbouder deleted the misc-fixes branch May 18, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bapplejax bapplejax bapplejax approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbouder @bapplejax