update dependencies #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phoenix616
requested changes
May 5, 2024
There was a problem hiding this comment.
Thank you for your PR updating it. The actual changes to the OpenInv loading logic seems solid as far as I can tell, will have to test it when I find the time (especially around the edge cases that the player retaining was supposed to help with in the past)
However you seem to have done a lot of changes that don't seem related to the functionality and are really only cosmetic. That makes reviewing it pretty hard as well as messes up the git history, I would advice using a minimal diff policy. Please revert those changes, if you want style changes/fixes then please do those in a separate PR.
FireInstall
force-pushed
the
upstreamDependencies
branch
3 times, most recently
from
56dff2a
to
79dce15
Compare
FireInstall
force-pushed
the
upstreamDependencies
branch
from
79dce15
to
8f7eee3
Compare
Phoenix616
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the dependencies to the newest (1.20.6) version.
Most importantly is OpenInv with a change in its public API, where "retainPlayer" is now marked for removal.
I know the way I aggressively pushed everything to the newest versions probably means loading this version on older Spigot/Paper versions doesn't work, but since there is version indifferent reflection, loading it in the api defined 1.13 could have been broken anyway.