-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinitiated pull request #11
base: android-testing
Are you sure you want to change the base?
Reinitiated pull request #11
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Generic High Entropy Secret | 4f0cd8a | local.properties | View secret | |
- | Generic High Entropy Secret | b92d567 | local.properties | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
restore-keys: | | ||
${{ runner.os }}-gradle- | ||
|
||
- name: Run AssessmentsSchoolHistoryDaoTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulling from previous pull request: This looks like a good hack, but does this mean every file to be tested would need to be added here? Lots of manual work and error prone approach? Shouldn't we automatically scan all files for tests and run them? There could be a better way to do this?
The action also seems to be failing: https://github.com/Mission-Prerna/Nipun-Lakshya-App/actions/runs/8534184385/job/23424912250?pr=11 |
All the required changes of deleting certain files have been done and I am creating pull request again