Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinitiated pull request #11

Open
wants to merge 15 commits into
base: android-testing
Choose a base branch
from

Conversation

Jasjot784
Copy link

All the required changes of deleting certain files have been done and I am creating pull request again

Copy link

gitguardian bot commented Apr 3, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic High Entropy Secret 4f0cd8a local.properties View secret
- Generic High Entropy Secret b92d567 local.properties View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

restore-keys: |
${{ runner.os }}-gradle-

- name: Run AssessmentsSchoolHistoryDaoTest

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulling from previous pull request: This looks like a good hack, but does this mean every file to be tested would need to be added here? Lots of manual work and error prone approach? Shouldn't we automatically scan all files for tests and run them? There could be a better way to do this?

@karntrehan
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants