Add podcast feed URL status indicator #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small design improvement for podcast status indicator - new icon and info text on hover: |
|
@MrChuckomo Have you look at this? |
MrChuckomo
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on issue #73.
This implementation creates new prop
feedUrlStatusinpoddycast-favorite_podcasts.json. This prop has value of200for working URL and500for broken URL.When user adds new podcast to his favorites, the default value of
feedUrlStatusis200. Every time the app, or user, fetches new episodes this prop is updated. If podcast data are fetched successfully,feedUrlStatusis set to200. If there is any error with the requestfeedUrlStatusis set to500.When user opens the "Favorites" view, an indicator is displayed based on the value of
feedUrlStatus. This indicator is red border around the podcast thumbnail image (this might need change; there might be red-ish thumbnails). This indicator is created through CSS and new class on the thumbnail image.Broken URL example:
Working URL example:
