Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: CAMtr_volume_mixing_ratio read issue #176

Merged

Conversation

scrasmussen
Copy link
Member

@scrasmussen scrasmussen commented Jan 9, 2024

TYPE: bugfix

KEYWORDS: read file, iso_fortran_env

SOURCE: Soren Rasmussen, NCAR

DESCRIPTION OF CHANGES: The iso_fortran_env constant iostat_end has replaced the traditional, but not defined by the Fortran standard, -1 to mean the end-of-file has been reached. This fix reflects that change that is starting to appear in some compilers.

TESTS CONDUCTED: The CLWRF -- clwrf -- CLWRF ALERT! statement had started appearing with the Cray compiler 15.0.1, without any change to the "CAMtr_volume_mixing_ratio.SSP245" input file. This warning message is not showing up anymore.

Checklist

Merging the PR depends on following checklist being completed. Add X between
each of the square brackets if they are completed in the PR itself. If a
bullet is not relevant to you, please comment on why below the bullet.

  • Closes issue #xxxx (An issue must exist or be created to be closed. The
    issue describes and documents the problem and general solution, the PR
    describes the technical details of the solution.)
  • Tests added (unit tests and/or regression/integration tests)
  • Backwards compatible
  • Requires new files? If so, how to generate them.
  • Fully documented

…l, but not defined by the standard, -1 to mean the end of a file has been reached. This fix reflects that change that is starting to appear in some compilers.
@gutmann gutmann merged commit 2065ee6 into NCAR:develop Jan 23, 2024
1 check passed
@scrasmussen scrasmussen deleted the bugfix/CAMtr_volume_mixing_ratio-read branch January 31, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants