Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command-line option for python MusicBox #172

Merged
merged 23 commits into from
Jul 16, 2024
Merged

Add command-line option for python MusicBox #172

merged 23 commits into from
Jul 16, 2024

Conversation

carl-drews
Copy link
Collaborator

Added a python main() to run MusicBox from the command line. Added a logger for command-line operation, possibly from cron().

@carl-drews carl-drews changed the title Carls main01 Add command-line option for python Music Jun 28, 2024
@carl-drews carl-drews changed the title Add command-line option for python Music Add command-line option for python MusicBox Jun 28, 2024
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! just a couple suggestions about default values, but looks go to go to me!

src/acom_music_box/music_box.py Outdated Show resolved Hide resolved
src/acom_music_box/music_box_conditions.py Outdated Show resolved Hide resolved
src/acom_music_box/music_box_model_options.py Outdated Show resolved Hide resolved
src/acom_music_box/music_box_logger.py Outdated Show resolved Hide resolved
src/acom_music_box/music_box.py Outdated Show resolved Hide resolved
src/acom_music_box/music_box_main.py Show resolved Hide resolved
src/acom_music_box/goMusicBox.bat Outdated Show resolved Hide resolved
Copy link
Collaborator

@K20shores K20shores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove *.bat files, otherwise looks good!

src/acom_music_box/goBuild.bat Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just a couple suggestions/questions

requirements.txt Outdated Show resolved Hide resolved
src/acom_music_box/goMusicBox.bat Outdated Show resolved Hide resolved
src/acom_music_box/music_box_main.py Outdated Show resolved Hide resolved
K20shores
K20shores previously approved these changes Jul 15, 2024
Copy link
Collaborator

@K20shores K20shores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing, otherwise it looks good!

.github/workflows/smoke_test.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@carl-drews
Copy link
Collaborator Author

Reviewers approved the pull request; ready to merge with main branch.

@mattldawson mattldawson merged commit d25b81d into main Jul 16, 2024
3 checks passed
@mattldawson mattldawson deleted the carls-main01 branch July 16, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants