Use uint16_t instead of uint8_t for semver tokens
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerJang27
force-pushed
the
larger-release-tokens
branch
2 times, most recently
from
64a44f2
to
b0d3bcc
Compare
|
Thanks! |
|
In general, can immediately uint32_t |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
uint16_tto expand valid semver to range from0.0.0to65535.65535.65535(rather than to255.255.255). This also applies to prerelease version numbers.This was a problem for tools like ruff, which is now at
0.0.270, as well as circleci, which is now atv0.1.26837. Using 2 bytes to represent each of the semver tokens should resolve this problem, as well as most other tools.