Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TSP App 2121-1 #263

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

MarcAntoine-Arnaud
Copy link
Contributor

update of #234

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #263 into master will decrease coverage by 1.31%.
The diff coverage is 2.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #263      +/-   ##
============================================
- Coverage     67.86%   66.54%   -1.32%     
  Complexity     1609     1609              
============================================
  Files           158      160       +2     
  Lines         11226    11457     +231     
  Branches       1701     1742      +41     
============================================
+ Hits           7618     7624       +6     
- Misses         2798     3023     +225     
  Partials        810      810
Impacted Files Coverage Δ Complexity Δ
...mflibrary/st2067_2/IMFCompositionPlaylistType.java 65.14% <ø> (ø) 25 <0> (ø) ⬇️
...brary/st2067_2/AbstractApplicationComposition.java 76.99% <ø> (ø) 89 <0> (ø) ⬇️
...ibrary/tsp_2121/ApplicationTsp2121Composition.java 0% <0%> (ø) 0 <0> (?)
...CompositionImageEssenceTsp2121DescriptorModel.java 0% <0%> (ø) 0 <0> (?)
...2067_2/CompositionImageEssenceDescriptorModel.java 73.42% <0%> (-0.64%) 91 <0> (ø)
.../main/java/com/netflix/imflibrary/Colorimetry.java 93.43% <100%> (+0.09%) 8 <0> (ø) ⬇️
...ibrary/st2067_2/ApplicationCompositionFactory.java 90.76% <100%> (+0.6%) 7 <0> (ø) ⬇️
...in/java/com/netflix/imflibrary/IMFConstraints.java 41.56% <0%> (-1.83%) 26% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d646f2...a030997. Read the comment docs.

@MarcAntoine-Arnaud
Copy link
Contributor Author

Hi @cconcolato,
Do you have time to check it soon ?

Best,
Marc-Antoine

@robjay
Copy link

robjay commented Dec 18, 2019

Hi, is there an ETA of this being released? I noticed that photon now supports application 5, but App 2121-1 is still waiting to be merged and released.

@MarcAntoine-Arnaud
Copy link
Contributor Author

@cconcolato do you have a little bit of time ?
Thanks

@robjay
Copy link

robjay commented Dec 19, 2019

@MarcAntoine-Arnaud, will you be extending this to support TSP 2121-4 ?

public enum ApplicationCompositionType {
APPLICATION_2_COMPOSITION_TYPE(Application2Composition.class, namespacesApplication2Composition),
APPLICATION_2E_COMPOSITION_TYPE(Application2ExtendedComposition.class, namespacesApplication2EComposition),
APPLICATION_5_COMPOSITION_TYPE(Application5Composition.class, namespacesApplication5Composition),
APPLICATION_TSP_2121_COMPOSITION_TYPE(ApplicationTsp2121Composition.class, namespacesApplicationTsp2121Composition),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSP 2121 has many parts. ApplicationTsp2121 could be replaced by ApplicationTsp2121Part1 or ApplicationDPPProRes.

@cconcolato
Copy link
Contributor

Could you add a test file that exercises the code you added? Code coverage is at 0% for ApplicationTsp2121Composition.java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants