Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear NEAR DA data on docker compose test env reset #272

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

Hyodar
Copy link
Contributor

@Hyodar Hyodar commented Jul 3, 2024

Current Behavior

NEAR DA data was not being cleared on a docker compose test env reset. The usual fix for this would be resetting the volumes whenever resetting - docker compose down -v or such. Still, this may pass unnoticed and cause some confusion.

A related PR is #267.

New Behavior

The above issue is prevented by clearing the relevant data on the indexer_setup service. So, when re-upping it should be clean even if the volumes were not reset.

Breaking Changes

None

@Hyodar Hyodar self-assigned this Jul 3, 2024
Copy link
Contributor

@mikhailUshakoff mikhailUshakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Copy link
Contributor

@emlautarom1 emlautarom1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Hyodar Hyodar merged commit 4595854 into main Jul 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants