Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: also support myroomnick to change roomnick #1349

Closed
wants to merge 2 commits into from

Conversation

BLumia
Copy link

@BLumia BLumia commented Feb 3, 2023

Related: https://invent.kde.org/network/neochat/-/merge_requests/780

Currently both Element, Cinny, FluffyChat and Quaternion supports /myroomnick to change user's room nick, leaves NeoChat and Nheko support /roomnick. When we introduce new user to the Matrix world and when they asking about how to change room nick, then we will need to state two answers to cover all these mainstream clients. It could be helpful to support a common command.

I'm not sure if there is a reason behind somewhere to keep supporting /roomnick so I add them both instead of replace roomnick to myroomnick. Hope that's okay and feel free to let me know if that needs to be changed.

@deepbluev7
Copy link
Member

I don't really agree with this. The "my" in "/myroomnick" makes no sense. Also /commands are not the right way to set your displayname anyway. You should just open your profile and set it there using the UI.

@BLumia
Copy link
Author

BLumia commented Feb 3, 2023

I don't really agree with this. The "my" in "/myroomnick" makes no sense.

I feel natural about whether /myroomnick or /roomnick is used, but my may be indicate it's changing the current user's roomnick instead of other people's roomnick. and there are also existing MSC that might introduce the ability to change other people's roomnick as well (MSC3015, MSC3865, etc)

/commands are not the right way to set your displayname anyway. You should just open your profile and set it there using the UI.

While I agree what these commands does should always available from UI, this description (open your profile and set it there using the UI) might be ambiguous if user just want to change their roomnick instead of their general display name that across all joined rooms.

Also, Nheko seems doesn't have a per-room user profile page (or I didn't find the entrance to trigger that UI) so I'm not sure where user can change their roomnick from UI edit: user need to click the member button, search for themself, and click the search result to open a per-room user profile page, and that page seems identical as the global one if user don't hover on the edit icon next to the nick name. But this might be a general UX issue which isn't related to this PR.

@deepbluev7
Copy link
Member

@labhub new-pipeline

@BLumia
Copy link
Author

BLumia commented Apr 4, 2023

Any progress on this? I'm not sure if it's going to be merged or should I close this one.

@LorenDB
Copy link
Member

LorenDB commented Apr 4, 2023

I'd vote to close it.

@BLumia BLumia closed this Apr 4, 2023
@BLumia BLumia deleted the myroomnick branch April 4, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants