sherlock: 0-unstable-2024-06-04 -> 0-unstable-2024-06-09 #313395
+52
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@applePrincess Upstream merged. Not sure if your build needs builds to succeed offline or not, but in case they do (as with rpms)... |
applePrincess
force-pushed
the
sherlock-tox
branch
3 times, most recently
from
8437d4f
to
20932f6
Compare
|
Indeed it needs to be offline to successfully build a package. (at least on Nixpkgs' GitHub Action and on Nixpkgs' hydra CI system) |
applePrincess
changed the title
applePrincess
changed the title
|
Result of 2 packages built:
|
applePrincess
force-pushed
the
sherlock-tox
branch
from
20932f6
to
e84a2a4
Compare
JohnRTitor
approved these changes
Jun 10, 2024
applePrincess
force-pushed
the
sherlock-tox
branch
from
e84a2a4
to
8f5431e
Compare
|
Done |
applePrincess
force-pushed
the
sherlock-tox
branch
from
8f5431e
to
1b31351
Compare
|
Moving to pkgs/by-name should be done in a seperate commit like 96f6a37. |
applePrincess
force-pushed
the
sherlock-tox
branch
from
1b31351
to
13d520c
Compare
|
Result of 2 packages built:
|
JohnRTitor
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update to 2024-06-09
sherlock-project/sherlock@ef124ac...d678908
I am notified by the upstream as sherlock-project/sherlock/issues/2111 and sherlock-project/sherlock/issues/2127 are almost ready which will use tox and poetry instead.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.