[14.0][IMP] rma_sale: improve onchange methods #335
Conversation
|
Hi @ernestotejeda, |
mt-software-de
force-pushed
the
14.0-rma-sale-improments
branch
5 times, most recently
from
adcad0c
to
b6b2bda
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
mt-software-de
force-pushed
the
14.0-rma-sale-improments
branch
from
b6b2bda
to
d9d5072
Compare
|
@rousseldenis could you please open this PR again? |
|
Hi @chienandalu, @ernestotejeda, |
github-actions
bot
removed
the
stale
- Onchange partner: Unset the order_id only if the new partner is not a child of the orders commercial partner - Onchange order: Set partner fields and procurement group - Onchange order and product: Change move and picking - Onchange picking: Change move
mt-software-de
force-pushed
the
14.0-rma-sale-improments
branch
from
d9d5072
to
3af6c84
Compare
|
ping @chienandalu do you have time for a review? |
|
You should check how it's done in 16.0, and backport it here, as that's a better way to go IMO. |
Thx. But i can not see any change which i can backport and matching my changes. |
|
I mean the conversion to computed writable fields. |
|
See 54e08e8 |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Changes:
_onchange_partner_id:
Before the order_id was always set to False
Now it's only set to False
if there is no partner selected or
the selected order_id.partner_id is not a child of the current selected partner_id.commercial_partner_id
_onchange_order_id:
if the order_id is set the corresponding partner_fields are getting set
New onchange methods:
_onchange_order_id_product_id:
if the order_id and the product_id is set
it tries to set the move_id with the latest shipped move with the same product_id
as well as the picking_id
_onchange_picking_id:
if the picking and product ist
tries to set the move by selecting the corresponding move