[14.0][ADD] rma_employee #393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankC013
force-pushed
the
14.0-rma_employee
branch
from
209a7b3
to
c97ff14
Compare
|
@eantones Please review! |
eantones
approved these changes
May 30, 2024
|
Which is the goal of using employees instead of users? Isn't this module a bit stripped without no extra features except the field? |
|
The objective of this module is to allow the user to assign an RMA to an employee. It's a purely informational field. It's created in a separate module to avoid the installation of HR when someone installs the RMA. |
|
But I insist: why not assigning a user instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation of a new module to add the employee field within the RMA model