[17.0][IMP] RMA - refactor to use procurement run #397
Conversation
|
Hi @chienandalu, @pedrobaeza, |
victoralmau
force-pushed
the
17.0-imp-rma-TT48789
branch
from
bb72bc4
to
6056913
Compare
|
Testing in the runboat http://oca-rma-17-0-pr397-605691345d56.runboat.odoo-community.org to return a delivery order marking the RMA option, I get:
|
|
Reviewing the error you indicate, I see that it is a side effect of something that already happens currently in v17 and v16, if the user does NOT have the locations permission, the picking that is created does NOT have the correct data (location and picking_type_id). This does not happen in tests because the user that is used does have this permission, I will review it to fix it. |
victoralmau
force-pushed
the
17.0-imp-rma-TT48789
branch
from
6056913
to
97a8d4c
Compare
The location_id field is important and its value is required, we need to add it to the wizard (even if it is hidden) so that it is saved and the picking is created correctly. Before, the location_id value was only saved (although the field was not in the wizard) if the user had the "Technical / Manage Multiple Stock Locations" permission.
Extra changes: - Change reception_move_ids to reception_move_id - Add test_rma_replace_pick_ship - Code and method reduction to simplify logic - Set route_ids (in/out) from procurements Co-authored-by: Michael Tietz TT48789
victoralmau
force-pushed
the
17.0-imp-rma-TT48789
branch
from
97a8d4c
to
ad115d1
Compare
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 0ab50bd. Thanks a lot for contributing to OCA. ❤️ |
FWP from 16.0: #402 + #392
Extra changes:
Please @pedrobaeza and @chienandalu can you review it?
@Tecnativa TT48789