OS2FRMS-11 cleanup and removal of permissions_by_term modules

[madsnorgaard]

No description provided.

[madsnorgaard]

@stanbellcom - apologies but I by mistake merged the PR expecting there to be some tests.

This was not my intention, however it was a clean PR and modules reported to not be in use. Lets have a session to fix or proceed with reviews. Let me know what you think is best.

[madsnorgaard]

FYI @skifter

[skifter]

@madsnorgaard Hey Mads

There is a reference from - 'drupal:permissions_by_term' to "os2forms_permissions_by_term"

We did not develop that module. Have you tested for that module.

Please revert the changes until that has been looked into.

Thanks :-)

[madsnorgaard]

Hey @skifter

I have just noticed this as well: #94

Attempted to call you up to discuss the best way forward. My understanding of the task was a complete removal of the modules os2forms_permissions_by_term, webform_permissions_by_term and permissions_by_term

[skifter]

Hi Mads

Please revert the changes until that has been looked into.

/Jørn

[madsnorgaard]

Let us take a quick dialogue tomorrow if needed because I can see several new commits and merges.

This PR addresses what you bring up in comment above and was submitted simultaneously as this PR for review: OS2Forms/os2forms#57

Additionally the task has been approved and merely require an uninstall of the modules prior to running the update/deploy.

Three modules to check if uninstalled:

1. permissions_by_term
2. os2forms_permissions_by_term
3. webform_permissions_by_term

Again, my apologies for the mistake and believe we can rather fix going forward rather than creating any git issues within you workflow - more than i have here.

@skifter

[skifter]

We only need permission_by_term uninstalled and removed. :-) Den 19.09.2023 kl. 23.12 skrev Mads Nørgaard:

Let us take a quick dialogue tomorrow if needed because I can see several new commits and merges. This PR addresses what you bring up in comment <#93 (comment)> above and was submitted simultaneously as this PR for review: OS2Forms/os2forms#57 <OS2Forms/os2forms#57> Additionally the task has been approved and merely require an uninstall of the modules prior to running the update/deploy. Three modules to check if uninstalled: 1. permissions_by_term 2. os2forms_permissions_by_term 3. webform_permissions_by_term Again, my apologies for the mistake and believe we can rather fix going forward rather than creating any git issues within you workflow - more than i have here. @skifter <https://github.com/skifter> — Reply to this email directly, view it on GitHub <#93 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGJ7LC5YQITUGZMMV7AGTDX3IDFVANCNFSM6AAAAAA43Q5IV4>. You are receiving this because you were mentioned.Message ID: ***@***.***>

-- De bedste hilsner Jørn Skifter Andersen IT Arkitekt Bellcom logo Bredgade 20 DK-6000 Kolding T: 70 26 00 85 M: 29 90 78 36 www.bellcom.dk <http://www.bellcom.dk> UDVIKLING <http://bellcom.dk/udvikling> · HOSTING <http://bellcom.dk/hosting> · SUPPORT <http://bellcom.dk/support>