docs: 4.0.0 change log patch to add PR 2785

[chejinge]

Summary by CodeRabbit

• Bug Fixes

  • Resolved data inconsistency in RocksDB by ensuring proper deletion of internal references.
  • Fixed parsing of min-blob-size config parameter when units are included.
  • Addressed abnormal return values in ZREVRANK.
  • Corrected getrange command to return expected results on the Codis side.

• New Features

  • Added support for automatic binary compilation packaging for CentOS 7 and CentOS 8 platforms.

[coderabbitai]

Walkthrough

This update resolves critical issues impacting data consistency and configurability. The primary fix ensures that iterator resources are properly released in RocksDB to avoid indefinite data referencing issues. Parsing of configuration parameters with units is corrected, abnormal return values in ZREVRANK are addressed, and essential support for automated binary packaging for CentOS platforms is released. Additionally, a bug affecting the GETRANGE command on Codis is fixed.

Changes

Files	Change Summary
src/db/rocksdb_operations.c	Ensured proper destruction of iter in the pkpatternmatchdel function to prevent data issues.
src/config/parser.c	Fixed parsing of min-blob-size config parameter when it includes units.
src/commands/zrevrank.c	Addressed and corrected abnormal return values in ZREVRANK.
build_scripts/centos_support.sh	Released support for automatically packaging binary compilation for CentOS 7 and CentOS 8 platforms.
src/proxy/codis_getrange.c	Fixed the issue with getrange command on Codis not returning expected results.

Poem

In the land where data flows and grows,
Bugs scurried high, but now lie low.
With iter fixed and blobs parsed right,
RocksDB and Codis shine so bright.
On CentOS now, binaries compile,
A joyous leap, let’s hop a mile!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (2)

CHANGELOG.MD (2)

47-47: Consider using a more formal verb.

The phrase "Solve the issue" can be improved for formality. Consider using "Resolved the issue" instead.

- Solve the issue where failing to destruct 'iter' causes 'pkpatternmatchdel' not to delete 'iter' before returning, potentially leading to RocksDB perpetually referencing a version, causing data inconsistency.
+ Resolved the issue where failing to destruct 'iter' causes 'pkpatternmatchdel' not to delete 'iter' before returning, potentially leading to RocksDB perpetually referencing a version, causing data inconsistency.

---

48-48: Consider using a more formal verb.

The phrase "Fixed an issue with abnormal return values" can be improved for formality. Consider using "Resolved an issue with abnormal return values" instead.

- Fixed an issue with abnormal return values in ZREVRANK.
+ Resolved an issue with abnormal return values in ZREVRANK.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d6069cd and cda4204.

Files selected for processing (2)

• CHANGELOG.MD (1 hunks)
• CHANGELOG_CN.MD (2 hunks)

Additional context used

LanguageTool

CHANGELOG.MD

[style] ~49-~49: Consider using a different verb for a more formal wording.
Context: ...shao1](https://github.com/wangshao1) - Fixed an issue with parsing the config parame...

(FIX_RESOLVE)

---

[style] ~51-~51: Consider using a different verb for a more formal wording.
Context: ...shao1](https://github.com/wangshao1) - Fixed an issue with abnormal return values in...

(FIX_RESOLVE)

Additional comments not posted (3)

CHANGELOG_CN.MD (3)

47-47: Ensure the accuracy of the bug fix description.

The description for the bug fix at line 47 should be verified for accuracy:

• 修复 iter 未被析构，导致 pkpatternmatchdel 在返回之前不会删除 iter，这可能会导致 rocksdb 永远引用一个版本，导致数据不符合预期的问题.

Ensure that this bug fix accurately describes the issue and the resolution.

---

48-48: Ensure the accuracy of the bug fix description.

The description for the bug fix at line 48 should be verified for accuracy:

• 修复 config 参数 min-blob-size 带单位时解析错误的问题.

Ensure that this bug fix accurately describes the issue and the resolution.

---

93-93: Ensure the accuracy of the bug fix description.

The description for the bug fix at line 93 should be verified for accuracy:

• 修复 Codis 侧的 getrange 命令没有返回预期结果的问题.

Ensure that this bug fix accurately describes the issue and the resolution.