Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #298 and workaround for Sybil 4 bug #303

Merged
merged 14 commits into from
May 18, 2023

Conversation

thirtytwobits
Copy link
Member

#298 will be fixed but this will also get another refactor when we switch to CETL.

@thirtytwobits
Copy link
Member Author

This PR is blocked by OpenCyphal/docker_toolchains#34

verification/.devcontainer/devcontainer.json Show resolved Hide resolved
src/nunavut/lang/py/support/serialization.j2 Outdated Show resolved Hide resolved
src/nunavut/lang/js/support/serialization.j2 Outdated Show resolved Hide resolved
src/nunavut/lang/html/support/serialization.j2 Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
src/nunavut/cli/__init__.py Show resolved Hide resolved
@thirtytwobits
Copy link
Member Author

For the love of Pete! Is the entire Python universe broken!?! (working on a fix for RTD)

Copy link
Member

@pavel-kirienko pavel-kirienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I get it correctly but CYPHAL_PATH contains the list of directories that contain DSDL root namespaces in them. That's how it's defined in PyCyphal et al. Is this compatible with the semantics of your env var here?

@thirtytwobits
Copy link
Member Author

Not sure if I get it correctly but CYPHAL_PATH contains the list of directories that contain DSDL root namespaces in them. That's how it's defined in PyCyphal et al. Is this compatible with the semantics of your env var here?

I believe so? Look at test_CYPHAL_PATH and let me know.

@pavel-kirienko
Copy link
Member

I believe so? Look at test_CYPHAL_PATH and let me know.

It seems like Nunavut expects the env vars to contain the list of root namespace directories, not the list of directories that contain root namespace directories in them. Observe:

outer/
    scotec/             <-- a DSDL root namespace
        Thing.1.0.dsdl
    ns/                 <-- a DSDL root namespace
        Foo.1.0.dsdl

CYPHAL_PATH would contain outer while your path variables would contain outer/scotec:outer/ns.

@thirtytwobits
Copy link
Member Author

It seems like Nunavut expects the env vars to contain the list of root namespace directories,...

Undoing then. Can you open an issue to add support for CYPHAL_PATH?

@sonarcloud
Copy link

sonarcloud bot commented May 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@thirtytwobits thirtytwobits merged commit f0cc6cd into OpenCyphal:main May 18, 2023
360 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants