Contribute: zfs driver and zfs driver shared over ISCSI #5654

openmilanese · 2021-11-29T16:48:50Z

I make available my integration work on zfs, based on the ceph driver.

zfs is for single node and zfs_iscsi for shared

https://github.com/openmilanese/zfs_iscsi.git
https://github.com/openmilanese/zfs.git

tinova · 2022-04-25T08:55:17Z

src/fireedge/etc/sunstone/admin/user-tab.yaml

+    enabled: true
+    actions:
+      change_authentication: true
+      update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:01Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:03Z

src/sunstone/etc/sunstone-views/mixed/cloud.yaml

+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:06Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:08Z

src/sunstone/etc/sunstone-views/mixed/admin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:10Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:12Z

src/sunstone/etc/sunstone-views/vcenter/cloud.yaml

+      settings_showback_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:15Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:17Z

src/sunstone/etc/sunstone-views/kvm/cloud.yaml

+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:19Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:21Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:24Z

src/sunstone/etc/sunstone-views/kvm/admin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:26Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:28Z

src/sunstone/etc/sunstone-views/kvm/cloud.yaml

+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:30Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:32Z

src/sunstone/etc/sunstone-views/kvm/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:35Z

src/sunstone/etc/sunstone-views/vcenter/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:37Z

src/sunstone/etc/sunstone-views/mixed/admin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:39Z

src/sunstone/etc/sunstone-views/vcenter/admin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:42Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:45Z

src/sunstone/etc/sunstone-views/mixed/cloud.yaml

+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

with user inputs * Fix error parsing vm template with user input * Retains the value of SOCKET input

* Fixes bug where min/max/cooldown fields would not be updated properly * Disables all role definition inputs when no role is being selected Signed-off-by: Victor Hansson <[email protected]>

Signed-off-by: Guillermo Ramos <[email protected]>

Signed-off-by: Victor Hansson <[email protected]>

Co-authored-by: Tino Vázquez <[email protected]>

Signed-off-by: Victor Hansson <[email protected]>

* Fixes handling of showback + accounting records - Previously only worked for groups * Fixes rendering of multichart XAxis labels - Now uses a custom XAxis component to truncate long label names - Displays the full name on hover * Fixes rendering of showback data in non-fullscreen - Now all 3 charts have sufficient screen space in both modes Signed-off-by: Victor Hansson <[email protected]>

* Changes the user input labels during service template instantiation to display the field description first * Loads default values for these fields now Signed-off-by: Victor Hansson <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

Co-authored-by: Tino Vázquez <[email protected]>

Signed-off-by: dcarracedo <[email protected]>

* Fix body_json for history record * Update the body_json on every VM update to keep the data synced with the xml body * Remove few duplicated VM updates

tinova · 2024-07-03T12:00:50Z

src/host/HostShareNUMA.cc

+        if (n_fhp > node_fhp)
+        {
+            node_id  = it->first;
+            node_fhp = n_fhp;


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

We observed that the presence of non-empty statements like a + b without clear context or purpose within the codebase can lead to potential confusion or misinterpretation. To mitigate this issue, it's advisable to ensure that such statements are appropriately integrated into larger constructs that contribute meaningfully to the program's logic or functionality. This could involve assigning the result of the expression to a variable.

tinova · 2024-07-03T12:00:57Z

src/lcm/LifeCycleActions.cc

+                        case VirtualMachine::DISK_SNAPSHOT_DELETE:
+                        case VirtualMachine::DISK_RESIZE:
+                        case VirtualMachine::UNKNOWN:
+                            is_error = true;


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

We observed that the presence of non-empty statements like a + b without clear context or purpose within the codebase can lead to potential confusion or misinterpretation. To mitigate this issue, it's advisable to ensure that such statements are appropriately integrated into larger constructs that contribute meaningfully to the program's logic or functionality. This could involve assigning the result of the expression to a variable.

tinova · 2024-07-03T12:00:59Z

src/image/ImageManagerProtocol.cc

+    }
+    else
+    {
+        error = true;


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

We observed that the presence of non-empty statements like a + b without clear context or purpose within the codebase can lead to potential confusion or misinterpretation. To mitigate this issue, it's advisable to ensure that such statements are appropriately integrated into larger constructs that contribute meaningfully to the program's logic or functionality. This could involve assigning the result of the expression to a variable.

tinova · 2024-07-03T12:01:11Z

src/image/Image.cc

@@ -758,6 +801,10 @@ int Image::set_type(string& _type, string& error)
    {
        type = CONTEXT;
    }
+    else if ( _type == "BACKUP" )
+    {
+        type = BACKUP;


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

We observed that the presence of non-empty statements like a + b without clear context or purpose within the codebase can lead to potential confusion or misinterpretation. To mitigate this issue, it's advisable to ensure that such statements are appropriately integrated into larger constructs that contribute meaningfully to the program's logic or functionality. This could involve assigning the result of the expression to a variable.

tinova · 2024-07-03T12:01:18Z

src/image/Image.cc

+            goto error_common;
+        }
+
+        state = READY;


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

We observed that the presence of non-empty statements like a + b without clear context or purpose within the codebase can lead to potential confusion or misinterpretation. To mitigate this issue, it's advisable to ensure that such statements are appropriately integrated into larger constructs that contribute meaningfully to the program's logic or functionality. This could involve assigning the result of the expression to a variable.

tinova · 2024-07-03T12:01:27Z

src/host/HostSharePCI.cc

+    if ( bus_index )
+    {
+        ibus = slot;
+        slot = 0;


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

We observed that the presence of non-empty statements like a + b without clear context or purpose within the codebase can lead to potential confusion or misinterpretation. To mitigate this issue, it's advisable to ensure that such statements are appropriately integrated into larger constructs that contribute meaningfully to the program's logic or functionality. This could involve assigning the result of the expression to a variable.

tinova · 2024-07-03T12:01:30Z

src/image/Image.cc

+    // State is LOCKED till the ImageManager copies it to the Repository.
+    // Backup Images set to READY as it is already in the repo
+    // -------------------------------------------------------------------------
+    state = LOCKED;


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

We observed that the presence of non-empty statements like a + b without clear context or purpose within the codebase can lead to potential confusion or misinterpretation. To mitigate this issue, it's advisable to ensure that such statements are appropriately integrated into larger constructs that contribute meaningfully to the program's logic or functionality. This could involve assigning the result of the expression to a variable.

tinova · 2024-07-03T12:01:34Z

src/lcm/LifeCycleActions.cc

+                    {
+                        // Do not trigger driver update in case no attribute was updated
+                        is_update = false;
+                        is_tmpl = true;


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

We observed that the presence of non-empty statements like a + b without clear context or purpose within the codebase can lead to potential confusion or misinterpretation. To mitigate this issue, it's advisable to ensure that such statements are appropriately integrated into larger constructs that contribute meaningfully to the program's logic or functionality. This could involve assigning the result of the expression to a variable.

tinova · 2024-07-03T12:01:39Z

src/monitor/src/data_model/VirtualMachineBase.cc

    {
-        attrs.clear();
-        public_cloud = (user_template->get("EC2", attrs) > 0);
+        user_template = nullptr;


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

We observed that the presence of non-empty statements like a + b without clear context or purpose within the codebase can lead to potential confusion or misinterpretation. To mitigate this issue, it's advisable to ensure that such statements are appropriately integrated into larger constructs that contribute meaningfully to the program's logic or functionality. This could involve assigning the result of the expression to a variable.

tinova · 2024-07-03T12:02:47Z

src/market/MarketPlace.cc

+    if (get_template_attribute("STATE", state_str) &&
+        str_to_state(state_str, state_new) == 0)
+    {
+        state = state_new;


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

We observed that the presence of non-empty statements like a + b without clear context or purpose within the codebase can lead to potential confusion or misinterpretation. To mitigate this issue, it's advisable to ensure that such statements are appropriately integrated into larger constructs that contribute meaningfully to the program's logic or functionality. This could involve assigning the result of the expression to a variable.

tinova · 2024-07-03T12:03:01Z

src/market/MarketPlaceManagerActions.cc

+                goto error_noimage;
+            }
+
+            if ( auto ds = dspool->get_ro(ds_id) )


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

This snippet may contain an accidental use of incorrect operation. Make sure that the operation being performed is in fact what you intended.

tinova · 2024-07-03T12:03:05Z

src/market/MarketPlaceManagerActions.cc

+        {
+            int ds_id;
+
+            if ( auto image = ipool->get_ro(origin_id) )


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

This snippet may contain an accidental use of incorrect operation. Make sure that the operation being performed is in fact what you intended.

tinova · 2024-07-03T12:03:22Z

src/monitor/src/data_model/VirtualMachineBase.cc

@@ -77,7 +77,7 @@ int VirtualMachineBase::init_attributes()

    xpath(action, "/VM/HISTORY_RECORDS/HISTORY/ACTION", -1);
    resume = (action == VMActions::STOP_ACTION || action == VMActions::UNDEPLOY_ACTION


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

This snippet may contain an accidental use of incorrect operation. Make sure that the operation being performed is in fact what you intended.

tinova · 2024-07-03T12:08:39Z

src/hm/HookStateVirtualNetwork.cc

+
+        if ( new_state != VirtualNetwork::INIT )
+        {
+            state = new_state;


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

We observed that the presence of non-empty statements like a + b without clear context or purpose within the codebase can lead to potential confusion or misinterpretation. To mitigate this issue, it's advisable to ensure that such statements are appropriately integrated into larger constructs that contribute meaningfully to the program's logic or functionality. This could involve assigning the result of the expression to a variable.

tinova · 2024-07-03T12:08:48Z

src/datastore/Datastore.cc

@@ -286,6 +285,10 @@ Datastore::DatastoreType Datastore::str_to_type(string& str_type)
    {
        dst = FILE_DS;
    }
+    else if ( str_type == "BACKUP_DS" )
+    {
+        dst = BACKUP_DS;


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

We observed that the presence of non-empty statements like a + b without clear context or purpose within the codebase can lead to potential confusion or misinterpretation. To mitigate this issue, it's advisable to ensure that such statements are appropriately integrated into larger constructs that contribute meaningfully to the program's logic or functionality. This could involve assigning the result of the expression to a variable.

tinova · 2024-07-03T12:15:37Z

src/common/NebulaUtil.cc

+    }
+
+    value = str;


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

We observed that the presence of non-empty statements like a + b without clear context or purpose within the codebase can lead to potential confusion or misinterpretation. To mitigate this issue, it's advisable to ensure that such statements are appropriately integrated into larger constructs that contribute meaningfully to the program's logic or functionality. This could involve assigning the result of the expression to a variable.

rsmontero force-pushed the master branch 4 times, most recently from 0b269ff to b94dad5 Compare December 14, 2021 16:49

rsmontero force-pushed the master branch from 2377a4e to 995f2d1 Compare March 25, 2022 13:00

tinova reviewed Apr 25, 2022

View reviewed changes

rsmontero force-pushed the master branch 2 times, most recently from 9e1985e to d019bd4 Compare April 28, 2022 14:43

rsmontero force-pushed the master branch from e4e6b6c to 04bbc74 Compare July 27, 2022 14:32

rsmontero force-pushed the master branch from 2024f62 to 3f300f3 Compare October 6, 2022 09:08

tinova reviewed Oct 18, 2022

View reviewed changes

jloboescalona2 and others added 14 commits June 25, 2024 17:38

B #6625: Error parsing VM Template instantiation (#3125)

2342005

with user inputs * Fix error parsing vm template with user input * Retains the value of SOCKET input

B #5833: Fix service template form (#3128)

0b6e58a

* Fixes bug where min/max/cooldown fields would not be updated properly * Disables all role definition inputs when no role is being selected Signed-off-by: Victor Hansson <[email protected]>

B #6630: Add DATASTORES/DS to host.xsd (#3129)

fe8c1ca

Signed-off-by: Guillermo Ramos <[email protected]>

F #5833: Add missing parents/rdp selector (#3130)

6c32a90

Signed-off-by: Victor Hansson <[email protected]>

M #~: Add more debug information for VMRC (#3131)

e731f41

Co-authored-by: Tino Vázquez <[email protected]>

F #6430: Make textcontroller area resizable (#3132)

42c0df3

Signed-off-by: Victor Hansson <[email protected]>

M #~: Removes login error message when user is not logged in! (#3135)

6144699

B #6637: fix vms graphs (#3137)

cbb26cf

Co-authored-by: Tino Vázquez <[email protected]>

M #-: Hook issues in translations (#3134)

10c3d4b

Signed-off-by: dcarracedo <[email protected]>

F #5861: Fix json history body (#3111)

31a238e

* Fix body_json for history record * Update the body_json on every VM update to keep the data synced with the xml body * Remove few duplicated VM updates

B #6589: Fix incorrect logic in resolve_networks function (#3126)

9d201cd

F #6553: Add oneflow error msgs to main oneflow server log file (#3127)

c8500c4

tinova reviewed Jul 3, 2024

View reviewed changes

		@@ -77,7 +77,7 @@ int VirtualMachineBase::init_attributes()

		xpath(action, "/VM/HISTORY_RECORDS/HISTORY/ACTION", -1);
		resume = (action == VMActions::STOP_ACTION \|\| action == VMActions::UNDEPLOY_ACTION

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Are you sure you want to change the base?

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Conversation

openmilanese commented Nov 29, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openmilanese commented Nov 29, 2021 •

edited

Loading