Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pure builds in Dockerfile #18

Closed
wants to merge 2 commits into from

Conversation

bddvlpr
Copy link

@bddvlpr bddvlpr commented Apr 28, 2024

Instead of builds being replicated half on the host machine and half containerized, this process should be fully containerized to prevent unwanted side effects on other machines and to allow for reproducible builds.

A follow-up PR for OpenShock/API will come after.

@LucHeart
Copy link
Member

Also missing CI integration

Also reworked CI at the same time.
@LucHeart
Copy link
Member

The CI would no longer run on PR's. It should still run on PR, but not push the image.
Also am not sure where you define the actual registry and image name on build-push action anymore? Doesnt seem like it specifics as tag at all

@bddvlpr
Copy link
Author

bddvlpr commented Apr 29, 2024

The CI would no longer run on PR's. It should still run on PR, but not push the image. Also am not sure where you define the actual registry and image name on build-push action anymore? Doesnt seem like it specifics as tag at all

The CI would still run on any PR, push or manual dispatch, see here. I don't see the point in building the Docker image on CI when it already is built in the Node CI, if you want I can refactor this.

Also am not sure where you define the actual registry and image name on build-push action anymore? Doesnt seem like it specifics as tag at all

docker/metadata-actions will extract metadata from the actions event such as a tag being built (it's ref) or branch puch (master, develop). As for the image name, check here.

@bddvlpr bddvlpr closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants