Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix requirements.txt #12605

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Conversation

wencan
Copy link
Contributor

@wencan wencan commented Jun 3, 2024

补上依赖 requests

@CLAassistant
Copy link

CLAassistant commented Jun 3, 2024

CLA assistant check
All committers have signed the CLA.

@Liyulingyue
Copy link
Collaborator

Liyulingyue commented Jun 4, 2024

Nice work!麻烦修复一下codestyple,在requirement最后加一个空行即可~

@jzhang533
Copy link
Collaborator

Nice work!麻烦修复一下codestyple,在requirement最后加一个空行即可~

加回车换行就可以。
这行也可以顺手改一下 : https://github.com/PaddlePaddle/PaddleOCR/blob/main/.github/workflows/tests.yaml#L26

@wencan
Copy link
Contributor Author

wencan commented Jun 5, 2024

Nice work!麻烦修复一下codestyple,在requirement最后加一个空行即可~

加回车换行就可以。 这行也可以顺手改一下 : https://github.com/PaddlePaddle/PaddleOCR/blob/main/.github/workflows/tests.yaml#L26

不懂workflows。这行的问题是?

@Liyulingyue
Copy link
Collaborator

Liyulingyue commented Jun 5, 2024

Nice work!麻烦修复一下codestyple,在requirement最后加一个空行即可~

加回车换行就可以。 这行也可以顺手改一下 : https://github.com/PaddlePaddle/PaddleOCR/blob/main/.github/workflows/tests.yaml#L26

不懂workflows。这行的问题是?

每一行要以换行符'\n'结尾,现在修改的情况是最后一行尾部没有包含换行符。
修改方式是在最后一行敲个回车(加个换行符)

@GreatV
Copy link
Collaborator

GreatV commented Jun 5, 2024

@wencan 那一行有requests,requirements.txt里加上以后,这里可以去掉了。

@wencan
Copy link
Contributor Author

wencan commented Jun 5, 2024

@Liyulingyue
requirements.txt补上了最后一行的\n
.github/workflows/tests.yaml的最后一行有\n,不缺requests,所以没动

@GreatV
Copy link
Collaborator

GreatV commented Jun 5, 2024

意思是把那里的 requests 删除掉,因为 requirements.txt 里已经有了。

@wencan
Copy link
Contributor Author

wencan commented Jun 5, 2024

@GreatV
Done

Copy link
Collaborator

@GreatV GreatV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzhang533 jzhang533 merged commit 08bd1dd into PaddlePaddle:main Jun 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants