generate: Add checksum validation for SSL modules #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanm defaults to downloading via http, so currently while there is a checksum for App::cpanminus there isn't a checksum or validation for the SSL modules installed. Rather than just switching to HTTPS, explicitly download the modules and verify the checksums, so the Docker image is built with known versions and checksums.
dgl
commented
Jul 2, 2024
zakame
added a commit
to zakame/docker-library-official-images
that referenced
this pull request
Jul 3, 2024
Also removes Debian Buster builds. - Perl/docker-perl#165 - Perl/docker-perl#163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpanm defaults to downloading via http, so currently while there is a checksum for App::cpanminus there isn't a checksum or validation for the SSL modules installed.
Rather than just switching to HTTPS, explicitly download the modules and verify the checksums, so the Docker image is built with known versions and checksums.
This obviously has the downside that future releases will need to be tracked manually, but I think that's a desirable thing in some ways, as the build of this docker image then becomes more reproducible.