Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

boilerplate implementation of SafariPublisher #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanielSinclair
Copy link

No description provided.

Copy link
Contributor

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM on this side 馃憤 Lots of verbose option for the safari key, it might confuse developer but I think the example key alleviates that problem 馃憤

"type": "number",
"description": "defaults to GITHUB_RUN_NUMBER"
},
"appleId": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all these emails required or they are optional, and if any of them exist, the internal use it? - Quite intriguing, might be a bit overwhelm to the dev that uses this? I wonder if some of these email are just duplicate of each other? (Tho I assume they need to be separated for fastlane?)

"type": "string",
"description": "i.e. \"18742801\" for Apple IDs in multiple teams"
},
"provisioningProfiles": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be constructed from the other piece of data? Or is the idea that user can either providing a provisionProfiles array VS providing the granular detail above as singular fields?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it seems to me the data in this profile object is the same as the data gathered so far above?

"type": "string",
"description": "for S3"
},
"workspace": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this for bpp or mainly for bms to test with?

@@ -20,5 +20,18 @@
"packageId": "123",
"csrftoken": "abcd",
"sessionid": "abcd"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants