Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add tip on artifact keys #9666

Merged
merged 8 commits into from
May 22, 2023
Merged

Docs: Add tip on artifact keys #9666

merged 8 commits into from
May 22, 2023

Conversation

serinamarie
Copy link
Contributor

@serinamarie serinamarie commented May 19, 2023 •
edited
Loading

Closes #9653

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement, docs.

@netlify
Copy link

netlify bot commented May 19, 2023 •
edited
Loading

✅ Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit c1da503
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/646b99745032110008c2dfec
😎 Deploy Preview https://deploy-preview-9666--prefect-docs-preview.netlify.app/concepts/artifacts
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@serinamarie serinamarie linked an issue May 19, 2023 that may be closed by this pull request
Docs: Highlight/explain benefits of artifacts with custom keys #9653
Closed
2 tasks
@serinamarie serinamarie marked this pull request as ready for review May 22, 2023 14:26
@serinamarie serinamarie requested a review from a team as a code owner May 22, 2023 14:26
@serinamarie serinamarie changed the title Add tip on artifact keys Docs: Add tip on artifact keys May 22, 2023
billpalombi
billpalombi approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@billpalombi billpalombi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd simplify the last sentence a bit but still this is an improvement. Thank you!

docs/concepts/artifacts.md Outdated Show resolved Hide resolved
docs/concepts/artifacts.md Outdated Show resolved Hide resolved
docs/concepts/artifacts.md Outdated Show resolved Hide resolved
billpalombi
billpalombi approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@billpalombi billpalombi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd simplify the last sentence a bit but still this is an improvement. Thank you!

zanieb
zanieb reviewed May 22, 2023
View reviewed changes
docs/concepts/artifacts.md Outdated Show resolved Hide resolved
discdiver
discdiver approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serinamarie serinamarie merged commit e382ac4 into main May 22, 2023
7 checks passed
@serinamarie serinamarie deleted the add-tip-on-artifact-keys branch May 22, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb left review comments

@billpalombi billpalombi billpalombi approved these changes

@discdiver discdiver discdiver approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Highlight/explain benefits of artifacts with custom keys
4 participants
@serinamarie @zanieb @billpalombi @discdiver