Add support for TIS Camera #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @kwang428 , First, I wanted to apologize for taking so long to get to this pull request. This is great work and we really appreciate your contributions. I made some small suggested edits to style to conform with PEP and the rest of the package. I changed the name of the file and the class to likewise conform. I also removed the `width` and `height` variables because the superclass encodes them in the `shape = (height, width)` attribute. I think the only changes to behavior that I did are: - remove a `/ 8` in the bitdepth variable. 24 = 3 * 8 implies 8-bit depth. - fix a comma bug in the else case of the woi function. Apart from some lingering concerns about the forced-RGB nature of the camera, it looks good. At this point, I am alright with pushing to main, but if you have time to test the current code on hardware, that would be preferred to pushing slightly untested code. Let me know what you think! Best, Ian
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #25 , here is a commit that integrates an Imaging Source Camera. One mysterious hard-coded factor in the code is a factor of 3 for RGB color. Even on monochromatic formats, the
tisgrabbercode still appears to return RGB color, where each component is the same. To obtain the image, this code just grabs the "R" component.Otherwise, I welcome any suggestions or changes!