enhance people view #113
Open
enhance people view #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suejinkim20
reviewed
Jun 13, 2024
| @@ -107,8 +107,7 @@ const HorizontalLettersMenu = ({ linkedLetters }) => { | |||
| } | |||
|
|
|||
| /* | |||
| * people are coming into this component from | |||
| * fetchStrapiPeople with this shape: | |||
| * people are coming into this component with this shape: | |||
There was a problem hiding this comment.
should we also filter the people array by the active field? currently it's pulling in both active and inactive staff members for the staff page
There was a problem hiding this comment.
ooh yes. thanks for catching that!
mbwatson
commented
Jun 13, 2024
lib/dashboard/people.js
Outdated
| return p.firstName.localeCompare(q.firstName) ? p.lastName.localeCompare(q.lastName) : -1 | ||
| }); | ||
|
|
||
| const ood = people.filter(person => person.teams.some(t => t.name === 'Office of the Director')); |
There was a problem hiding this comment.
use dashboard uid or slug
mbwatson
force-pushed
the
bugfix/alpha-people
branch
from
b45785e
to
eda256e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR aims to list people on the the
/peopleview alphabetically. a couple related efforts are folded in here: