Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/prettier #114

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Feature/prettier #114

wants to merge 6 commits into from

Conversation

Woozl
Copy link
Member

@Woozl Woozl commented Jun 13, 2024

Adds:

  • npm run format -> formats entire codebase
  • npm run check-format -> checks entire codebase
  • vscode format on save settings

We can add a CI step later to check PRs in the future.

@suejinkim20 could you verify the VSCode settings work when you pull this branch? Just make any formatting (mess up spacing, change quotes, etc) and save to see if it automatically fixes it.

@mbwatson can you check the npm scripts' functionality and also add docs for sublime auto-formatting suggestions

Copy link
Member

@mbwatson mbwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work as expected. i added a note about sublime text to the readme.

Copy link
Collaborator

@suejinkim20 suejinkim20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works for me too on vscode!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants