added max_time to calibration settings #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r change, so that multiprocessing results are all evaluated and not unnecessarily stopped by either max_time or max_iterations
jkriwet
changed the title
FWuellhorst
approved these changes
Apr 8, 2024
|
|
||
| if time.perf_counter() - self.start_time > self.max_time: | ||
| raise MaxTimeReached( | ||
| f"Terminating calibration as the maximum time of {self.max_time}s has been " |
There was a problem hiding this comment.
Whitespace between number and unit
| @@ -113,6 +113,7 @@ def __init__(self, | |||
| self.perform_square_deviation = kwargs.pop("square_deviation", False) | |||
| self.result_path = kwargs.pop('result_path', None) | |||
| self.max_itercount = kwargs.pop('max_itercount', np.inf) | |||
| self.max_time = kwargs.pop('max_time', np.inf) | |||
There was a problem hiding this comment.
Can you add this to the docstring?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to set a maximum calibration time. Added general check for max_iteration and max_time and changed place of that, so that when using multiprocessing a termination is only done after the results of one multiprocessing round are evaluated, to not unnecessarily ignore finished results.
Closes #55