Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min-max to avoid errors and actually increase control quality. #20

Merged
merged 1 commit into from
Aug 5, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions BESMod/Systems/Ventilation/Control/SummerPIDByPass.mo
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@ model SummerPIDByPass "Bypass the HEX in summer"

Modelica.Blocks.Math.MinMax minMaxMea(final nu=distributionParameters.nParallelDem)
annotation (Placement(transformation(extent={{-88,32},{-68,52}})));
Modelica.Blocks.Sources.Constant constZero1(k=distributionParameters.TDem_nominal[
1])
"Bypass is not used"
annotation (Placement(transformation(extent={{-82,-30},{-62,-10}})));
Modelica.Blocks.Math.MinMax minMaxSet(final nu=distributionParameters.nParallelDem)
annotation (Placement(transformation(extent={{-78,-50},{-58,-30}})));
equation
connect(summerByPass.TOda, weaBus.TDryBul) annotation (Line(points={{-35.2,26},
{-44,26},{-44,68},{1,68},{1,98}}, color={0,0,127}), Text(
Expand Down Expand Up @@ -45,6 +43,12 @@ equation
horizontalAlignment=TextAlignment.Right));
connect(minMaxMea.yMax, summerByPass.TMea) annotation (Line(points={{-67,48},{
-52,48},{-52,11},{-35.2,11}}, color={0,0,127}));
connect(summerByPass.TZoneSet, constZero1.y) annotation (Line(points={{-35.2,
-4},{-34,-4},{-34,-20},{-61,-20}}, color={0,0,127}));
connect(minMaxSet.u, useProBus.TZoneSet) annotation (Line(points={{-78,-40},{-78,
-38},{-82,-38},{-82,-60},{-103,-60}}, color={0,0,127}), Text(
string="%second",
index=1,
extent={{-6,3},{-6,3}},
horizontalAlignment=TextAlignment.Right));
connect(minMaxSet.yMin, summerByPass.TZoneSet) annotation (Line(points={{-57,-46},
{-35.2,-46},{-35.2,-4}}, color={0,0,127}));
end SummerPIDByPass;