Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Remove Edge and OneDrive (without winget) #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zoicware
Copy link

@zoicware zoicware commented Jun 4, 2024

added two functions to remove edge and onedrive instead of trying to use winget
works on 10 and 11 (latest)

@Raphire
Copy link
Owner

Raphire commented Jun 23, 2024

Heya,

Thanks for taking the time to contribute 😄

As I said in #64 I am not a huge fan of force removing applications this way, as it does open the door to many issues if anything changes in the way these apps are installed.

I do feel like this approach is somewhat justified for edge, considering how nigh impossible it is to uninstall in most regions. However, I see little reason to force remove OneDrive like this as the current implementation via WinGet works quite well. Is there a specific reason to include Onedrive here too?

@zoicware
Copy link
Author

Heya,

Thanks for taking the time to contribute 😄

As I said in #64 I am not a huge fan of force removing applications this way, as it does open the door to many issues if anything changes in the way these apps are installed.

I do feel like this approach is somewhat justified for edge, considering how nigh impossible it is to uninstall in most regions. However, I see little reason to force remove OneDrive like this as the current implementation via WinGet works quite well. Is there a specific reason to include Onedrive here too?

yep, microsoft insist on further baking edge into the os. I included onedrive since if the user doesnt have or doesnt want winget installed the script sill functions as it should, I dont think it makes sense to do it that way when it can be done natively with powershell but ofc this is your script :)

@Raphire Raphire force-pushed the master branch 3 times, most recently from 53dcb06 to 589f2e8 Compare June 26, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants