Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach command on Choice for translator #9855

Closed
wants to merge 3 commits into from

Conversation

Soheab
Copy link
Contributor

@Soheab Soheab commented Jun 4, 2024

Summary

This PR adds a command property to app_commands.Choice that can only be used to access the.. command inside the translator's translate method.

I wasn't sure on always attaching the command on the Choice since it doesn't store any state and is pretty lightweight.

Why?

Currently, there is no way to access the command if context.location is TranslationContextLocation.choice_name in app_commands.Translator.translate which is useful for implementations that store the strings per command name.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Rapptz
Copy link
Owner

Rapptz commented Jun 4, 2024

locale_str contains kwargs which allows you to specify as much extra information as possible when constructing it, so this should really not be necessary, especially since it kind of bloats up the model.

@Rapptz Rapptz closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants