Attach command on Choice for translator #9855
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
command
property toapp_commands.Choice
that can only be used to access the.. command inside the translator's translate method.I wasn't sure on always attaching the command on the Choice since it doesn't store any state and is pretty lightweight.
Why?
Currently, there is no way to access the command if
context.location
isTranslationContextLocation.choice_name
inapp_commands.Translator.translate
which is useful for implementations that store the strings per command name.Checklist