Update Premium Buttons #9864
Merged
Update Premium Buttons #9864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoCx1000
reviewed
Jun 14, 2024
Rapptz
requested changes
Jun 14, 2024
discord/ui/button.py
Outdated
Comment on lines
277
to
283
| .. note:: | ||
|
|
||
| Buttons with a URL cannot be created with this function. | ||
| Buttons with a URL or SKU cannot be created with this function. | ||
| Consider creating a :class:`Button` manually instead. | ||
| This is because buttons with a URL do not have a callback | ||
| associated with them since Discord does not do any processing | ||
| with it. | ||
| with it, and buttons with a SKU are handled by Discord. |
There was a problem hiding this comment.
This should probably be:
.. note::
Buttons with a URL or an SKU cannot be created with this function.
Consider creating a :class:`Button` manually instead.
This is because these buttons cannot have a callback
associated with them since Discord does not do any processing
with them.
Co-authored-by: Danny <[email protected]>
Rapptz
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
So Discord updated the premium interacion buttons and the current implementation needs some changes (+ some fixes).
Checklist