Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump NDK version #2016

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

chore: Bump NDK version #2016

wants to merge 2 commits into from

Conversation

BenjaminHalko
Copy link
Sponsor Member

A plugin says it requires NDK version 26.1.10909125, so the NDK version has been changed from flutter.ndkVersion to 26.1.10909125

A plugin says it requires NDK version `26.1.10909125`, so the NDK version has been changed from `flutter.ndkVersion` to `26.1.10909125`
@oSumAtrIX
Copy link
Member

I don't know if this is right. From what I saw building still worked

@BenjaminHalko
Copy link
Sponsor Member Author

Yep, building still works, but you get this error:
image

@BenjaminHalko

This comment was marked as outdated.

@BenjaminHalko

This comment was marked as resolved.

@oSumAtrIX
Copy link
Member

Yep, building still works, but you get this error:

Which plugin causes this. This wasn't an issue before.

@BenjaminHalko
Copy link
Sponsor Member Author

It might have happened after upgrading intl to 0.19.0 which is necessary to use flutter_localizations, but it is hard to say for certain. It has been happening for at least a month judging from the build logs, but any further and the logs have been deleted.

@oSumAtrIX
Copy link
Member

A git bisect should be helpful finding the commit, or it may be that plugin, even though it's actually a dependency. I don't know if it's correct practice to simply just pin the ndk version. It is set to flutter.ndkVersion by default for a reason

@BenjaminHalko
Copy link
Sponsor Member Author

The other option is to simply get rid of ndkVersion all together and it will instead use the NDK version provided by the AGP. This gets rid of the error.

@oSumAtrIX
Copy link
Member

What's the reason for it being set to flutter.ndkVersion

@BenjaminHalko
Copy link
Sponsor Member Author

OK, so flutter.ndkVersion is an NDK version that is supposedly the "most compatible" with the flutter framework. I think currently it is 23.something

@BenjaminHalko
Copy link
Sponsor Member Author

But you are fully allowed to change the NDK version if there is a version mismatch.

@oSumAtrIX
Copy link
Member

Why would the intl dependency rely on an NDK not most compatible with Flutter. I think downgrading the library makes more sense

@BenjaminHalko
Copy link
Sponsor Member Author

BenjaminHalko commented Jun 30, 2024

Unfortunately, flutter_localizations depends on intl 0.19.0 and flutter_localizations is from the flutter SDK. That said other plugins that have been recently updated/added are skeletons and file_picker. So it might be one of those...

Edit: Error was present before upgrading skeletons

Edit: After looking at the source code of file_picker, it doesn't seem to require a specific NDK version.

@BenjaminHalko
Copy link
Sponsor Member Author

It could have been a dependency of a package that got upgraded...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants