feat(Instagram): Add `Hide ads` patch #3380

tymmesyde · 2024-06-25T01:35:47Z

Hide Instagram ads

oSumAtrIX · 2024-06-25T01:37:51Z

src/main/kotlin/app/revanced/patches/instagram/patches/ad/fingerprints/AdInjectorFingerprint.kt

+import com.android.tools.smali.dexlib2.AccessFlags
+import com.android.tools.smali.dexlib2.Opcode
+
+internal object AdInjectorFingerprint : MethodFingerprint(


Is this a general ad injector or only for profiles?

General injector

Is the previous timeline ads patch necessary then?

I don't think so, i wanted to ask if i should remove it ?

That makes sense. Are reel ads included? If not, it may be good to add a description to explain what kind of ads are hidden.

Yes, stories, discover, profile etc..
The only place that i could still find some is when you reload your timeline by pulling the top, an ad can get injected in the first post

I believe the current timeline ads patch does hide that. Perhaps combining both patches makes sense? The only issue would be that the patch would be constrained to some older version. The alternative would be to note this behaviour in the description

I will add this behavior in the description

welcome · 2024-06-27T20:25:45Z

Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution.

# [4.11.0-dev.1](v4.10.1-dev.2...v4.11.0-dev.1) (2024-06-27) ### Features * Add `Remove share targets` patch ([#3334](#3334)) ([9414122](9414122)) * **Instagram:** Add `Hide ads` patch ([#3380](#3380)) ([c6b2f8c](c6b2f8c)) * **RAR:** Add `Hide purchase reminder` patch ([#3321](#3321)) ([8fbe7e3](8fbe7e3)) * **Stocard:** Add `Hide offers tab` and `Hide story bubbles` patch ([#3359](#3359)) ([fbd0507](fbd0507))

cyberboh · 2024-06-28T04:29:44Z

INFO: Hide ads succeeded
SEVERE: Hide timeline ads failed:
app.revanced.patcher.patch.PatchException: Failed to resolve ShowAdFingerprint
        at app.revanced.util.BytecodeUtilsKt.getException(BytecodeUtils.kt:27)
        at app.revanced.patches.instagram.patches.ads.timeline.HideTimelineAdsPatch.execute(HideTimelineAdsPatch.kt:61)
        at app.revanced.patches.instagram.patches.ads.timeline.HideTimelineAdsPatch.execute(HideTimelineAdsPatch.kt:16)
        at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Patcher.kt:173)
        at app.revanced.patcher.Patcher$apply$1.invokeSuspend(Patcher.kt:205)
        at app.revanced.patcher.Patcher$apply$1.invoke(Patcher.kt)
        at app.revanced.patcher.Patcher$apply$1.invoke(Patcher.kt)
        at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:61)
        at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:230)
        at app.revanced.cli.command.PatchCommand$run$4$1$1.invokeSuspend(PatchCommand.kt:303)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
        at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:280)
        at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
        at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
        at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
        at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:302)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
        at picocli.CommandLine.execute(CommandLine.java:2170)
        at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)

What's the benefit keeping both patches?
If Hide timeline ads already replaced by Hide ads, you should remove broken patches

oSumAtrIX · 2024-06-28T08:57:00Z

Refer to #3380 (comment)

cyberboh · 2024-06-28T09:22:29Z

Refer to #3380 (comment)

In the descriptions:
description = "Hides ads in stories, discover, profile, etc."
Is that different from Hide timeline ads does?

tymmesyde · 2024-06-28T09:31:55Z

Refer to #3380 (comment)

In the descriptions: description = "Hides ads in stories, discover, profile, etc." Is that different from Hide timeline ads does?

Yes, the previous patch only hid ads on the home feed
This one hides them almost everywhere

cyberboh · 2024-06-28T10:46:36Z

Refer to #3380 (comment)

In the descriptions: description = "Hides ads in stories, discover, profile, etc." Is that different from Hide timeline ads does?

Yes, the previous patch only hid ads on the home feed This one hides them almost everywhere

As I thought before.
So, Hide timeline ads patch should be removed in favor of Hide ads patch.
May be you can make a PR for it.

# [4.11.0](v4.10.0...v4.11.0) (2024-07-11) ### Bug Fixes * **Boost for reddit - Fix missing audio in video downloads:** Replace correct strings ([#3379](#3379)) ([b43db98](b43db98)) * **Windy - Unlock pro:** Revert changing package name ([#3402](#3402)) ([541f1e7](541f1e7)) * **Windy - Unlock pro:** Use correct package name ([#3397](#3397)) ([1d8459a](1d8459a)) * **YouTube - Hide layout components:** Detect if a keyword filter hides all videos ([#3365](#3365)) ([6aa47ec](6aa47ec)) * **YouTube - Settings:** Move some settings to different menus, adjust default setting values ([#3415](#3415)) ([7201ac4](7201ac4)) * **YouTube - SponsorBlock:** Skip segments when casting ([#3331](#3331)) ([d9395fd](d9395fd)) ### Features * Add `Remove share targets` patch ([#3334](#3334)) ([9414122](9414122)) * Add translations ([#2963](#2963)) ([69ea6f3](69ea6f3)) * **Bandcamp:** Add `Remove play limits` patch ([#3366](#3366)) ([ad8d3bb](ad8d3bb)) * **Instagram:** Add `Hide ads` patch ([#3380](#3380)) ([c6b2f8c](c6b2f8c)) * **RAR:** Add `Hide purchase reminder` patch ([#3321](#3321)) ([8fbe7e3](8fbe7e3)) * **Soundcloud:** Add `Hide ads` and `Disable telemetry` patch ([#3386](#3386)) ([3c79f3d](3c79f3d)) * **Stocard:** Add `Hide offers tab` and `Hide story bubbles` patch ([#3359](#3359)) ([fbd0507](fbd0507))

ani9730 · 2024-07-12T01:02:48Z

What version of instagram is this tested on ?

oSumAtrIX · 2024-07-12T01:06:05Z

Latest

cyberboh · 2024-07-12T12:11:06Z

@Neon329 See my comment above you. That patch should be removed because already replaced by Hide ads. Exclude it and it will work.

vsavovski · 2024-07-17T19:10:24Z

Last working version v339.0.0.30.105, version v340.0.0.22.109 fails.

feat(Instagram): Add Hide Ads patch

293c81d

tymmesyde mentioned this pull request Jun 25, 2024

feat(Instagram): Add Hide profile ads patch #3371

Closed

oSumAtrIX reviewed Jun 25, 2024

View reviewed changes

tymmesyde and others added 2 commits June 25, 2024 03:54

feat(Instagram): add Hide Ads description

192d0ea

refactor

357001b

oSumAtrIX approved these changes Jun 27, 2024

View reviewed changes

oSumAtrIX changed the title ~~feat(Instagram): Add Hide Ads patch~~ feat(Instagram): Add Hide ads patch Jun 27, 2024

oSumAtrIX merged commit c6b2f8c into ReVanced:dev Jun 27, 2024
2 checks passed

This comment was marked as off-topic.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Instagram): Add `Hide ads` patch #3380

feat(Instagram): Add `Hide ads` patch #3380

tymmesyde commented Jun 25, 2024

oSumAtrIX Jun 25, 2024

tymmesyde Jun 25, 2024

oSumAtrIX Jun 25, 2024

tymmesyde Jun 25, 2024

oSumAtrIX Jun 25, 2024

tymmesyde Jun 25, 2024 •

edited

Loading

oSumAtrIX Jun 25, 2024 •

edited

Loading

tymmesyde Jun 25, 2024

welcome bot commented Jun 27, 2024

cyberboh commented Jun 28, 2024

oSumAtrIX commented Jun 28, 2024

cyberboh commented Jun 28, 2024

tymmesyde commented Jun 28, 2024

cyberboh commented Jun 28, 2024

ani9730 commented Jul 12, 2024

oSumAtrIX commented Jul 12, 2024

This comment was marked as off-topic.

cyberboh commented Jul 12, 2024

vsavovski commented Jul 17, 2024

feat(Instagram): Add Hide ads patch #3380

feat(Instagram): Add Hide ads patch #3380

Conversation

tymmesyde commented Jun 25, 2024

oSumAtrIX Jun 25, 2024

Choose a reason for hiding this comment

tymmesyde Jun 25, 2024

Choose a reason for hiding this comment

oSumAtrIX Jun 25, 2024

Choose a reason for hiding this comment

tymmesyde Jun 25, 2024

Choose a reason for hiding this comment

oSumAtrIX Jun 25, 2024

Choose a reason for hiding this comment

tymmesyde Jun 25, 2024 • edited Loading

Choose a reason for hiding this comment

oSumAtrIX Jun 25, 2024 • edited Loading

Choose a reason for hiding this comment

tymmesyde Jun 25, 2024

Choose a reason for hiding this comment

welcome bot commented Jun 27, 2024

cyberboh commented Jun 28, 2024

oSumAtrIX commented Jun 28, 2024

cyberboh commented Jun 28, 2024

tymmesyde commented Jun 28, 2024

cyberboh commented Jun 28, 2024

ani9730 commented Jul 12, 2024

oSumAtrIX commented Jul 12, 2024

This comment was marked as off-topic.

cyberboh commented Jul 12, 2024

vsavovski commented Jul 17, 2024

feat(Instagram): Add `Hide ads` patch #3380

feat(Instagram): Add `Hide ads` patch #3380

tymmesyde Jun 25, 2024 •

edited

Loading

oSumAtrIX Jun 25, 2024 •

edited

Loading