-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add donation page #117
Conversation
c830775
to
ad5893f
Compare
Deployed at https://head.revanced.pages.dev. |
Deployed at https://e003377d.revanced.pages.dev. |
@Ushie Maybe fix and merge? :) |
I lack the frontend knowledge to carry on this PR, but I'll attempt it tonight |
Deployed at https://890ff77a.revanced.pages.dev. |
@oSumAtrIX Do you have any idea how this would look like? |
Deployed at https://35ec264e.revanced.pages.dev. |
Deployed at https://c1194c7c.revanced.pages.dev. |
Deployed at https://837599e4.revanced.pages.dev. |
Deployed at https://d314deb8.revanced.pages.dev. |
Deployed at https://cc948904.revanced.pages.dev. |
Deployed at https://d5c702e7.revanced.pages.dev. |
Deployed at https://head.revanced.pages.dev. |
Deployed at https://689ffbc9.revanced.pages.dev. |
@xafn Removing the border-radius from the image would look like this: Before: The reason for this is that it may look odd due to the high difference in contrast. Because there is a lot of light in the corners, the eye pupil closes to prevent too much light from getting in. When it closes, due to less lightness, the contrast of the card background and the actual website background is reduced resulting in a perceived rounding of the card background at the corners in a low light environment as illustrated: msedge_nbOPaPG000.mp4 |
I'm not sure I follow what this means, are you saying the high contrast makes the corners look more rounded that what they really are? |
Deployed at https://head.revanced.pages.dev. |
Deployed at https://head.revanced.pages.dev. |
Deployed at https://6221c91f.revanced.pages.dev. |
Deployed at https://6b208922.revanced.pages.dev. |
Deployed at https://1887043e.revanced.pages.dev. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the images optimized for web?
Deployed at https://298f40e2.revanced.pages.dev. |
Deployed at https://head.revanced.pages.dev. |
Deployed at https://dc490336.revanced.pages.dev. |
msedge_4uozqf6ibi.mp4
About
This PR aims to add a donation page that can be linked instead of the donation options separately everywhere.
TODO
Shorten crypto key strings to the following format:Decided against, keys arent as long as expectedD8G...LXp
(How to handle this on mobile?)