Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add donation page #117

Merged
merged 33 commits into from
Aug 9, 2023
Merged

feat: add donation page #117

merged 33 commits into from
Aug 9, 2023

Conversation

oSumAtrIX
Copy link
Member

@oSumAtrIX oSumAtrIX commented Jun 10, 2023

msedge_4uozqf6ibi.mp4

About

This PR aims to add a donation page that can be linked instead of the donation options separately everywhere.

TODO

  • Resolve duplicate heart SVG and the path in the nav bar
  • Improve responsiveness
  • Proper padding of the pulsating logo
  • Improve semantics of the donation page text content
  • Add a "Copied" tooltip to the crypto keys
  • Shorten crypto key strings to the following format: D8G...LXp (How to handle this on mobile?) Decided against, keys arent as long as expected
  • Add QR codes to crypto keys
  • Instead of hardcoding donation links and keys, use API

@revanced-bot
Copy link

Deployed at https://head.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://e003377d.revanced.pages.dev.

@alexandreteles
Copy link

@Ushie Maybe fix and merge? :)

@Ushie
Copy link
Member

Ushie commented Aug 1, 2023

I lack the frontend knowledge to carry on this PR, but I'll attempt it tonight

@revanced-bot
Copy link

Deployed at https://890ff77a.revanced.pages.dev.

@Ushie
Copy link
Member

Ushie commented Aug 2, 2023

Add QR codes to crypto keys

@oSumAtrIX Do you have any idea how this would look like?

@revanced-bot
Copy link

Deployed at https://35ec264e.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://c1194c7c.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://837599e4.revanced.pages.dev.

@Ushie Ushie linked an issue Aug 2, 2023 that may be closed by this pull request
2 tasks
@revanced-bot
Copy link

Deployed at https://d314deb8.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://cc948904.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://d5c702e7.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://head.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://689ffbc9.revanced.pages.dev.

@oSumAtrIX
Copy link
Member Author

@xafn Removing the border-radius from the image would look like this:

image

Before:

image

The reason for this is that it may look odd due to the high difference in contrast. Because there is a lot of light in the corners, the eye pupil closes to prevent too much light from getting in. When it closes, due to less lightness, the contrast of the card background and the actual website background is reduced resulting in a perceived rounding of the card background at the corners in a low light environment as illustrated:

msedge_nbOPaPG000.mp4

@xafn
Copy link
Contributor

xafn commented Aug 9, 2023

The reason for this is that it may look odd due to the high difference in contrast. Because there is a lot of light in the corners, the eye pupil closes to prevent too much light from getting in. When it closes, due to less lightness, the contrast of the card background and the actual website background is reduced resulting in a perceived rounding of the card background at the corners in a low light environment as illustrated:

I'm not sure I follow what this means, are you saying the high contrast makes the corners look more rounded that what they really are?

@revanced-bot
Copy link

Deployed at https://head.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://head.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://6221c91f.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://6b208922.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://1887043e.revanced.pages.dev.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the images optimized for web?

@revanced-bot
Copy link

Deployed at https://298f40e2.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://head.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://dc490336.revanced.pages.dev.

@xafn xafn merged commit 806a5de into dev Aug 9, 2023
3 checks passed
@Ushie Ushie deleted the donation branch January 20, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: donations page
6 participants