Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAI-24760 Handle token directory creation #103

Merged
merged 2 commits into from
Jul 12, 2024
Merged

RAI-24760 Handle token directory creation #103

merged 2 commits into from
Jul 12, 2024

Conversation

ginal
Copy link
Contributor

@ginal ginal commented Apr 12, 2024

Create the token cache directory if the directory does not exist.

@larf311
Copy link

larf311 commented Apr 12, 2024

Please add tests.

@ginal ginal force-pushed the create-token-dir branch 3 times, most recently from edbbfad to 66bc941 Compare June 28, 2024 13:41
@ginal
Copy link
Contributor Author

ginal commented Jun 28, 2024

Added tests.

@Akrion
Copy link

Akrion commented Jul 11, 2024

I tested the main and this branch running the unit tests. In main I get no errors but in this branch I do get:

error deleting token cache file directory: /Users/ialexiev/.rai: remove /Users/ialexiev/.rai: directory not empty

CleanShot 2024-07-11 at 15 11 23@2x

All tests pass both cases though

@ginal
Copy link
Contributor Author

ginal commented Jul 11, 2024

I tested the main and this branch running the unit tests. In main I get no errors but in this branch I do get:

error deleting token cache file directory: /Users/ialexiev/.rai: remove /Users/ialexiev/.rai: directory not empty

I have updated the commit and removed the error logging.

@ginal ginal requested a review from Akrion July 11, 2024 18:02
@ginal ginal merged commit 136ae26 into main Jul 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants