Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock multipart response without relation id from arrow part name #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NRHelmi
Copy link
Contributor

@NRHelmi NRHelmi commented May 31, 2023

More context in this jira ticket https://relationalai.atlassian.net/browse/RAI-12507

@NRHelmi NRHelmi marked this pull request as ready for review May 31, 2023 10:36
@denisgursky
Copy link
Contributor

denisgursky commented Jun 1, 2023

Hm, I thought that we were going to send 0.arrow as the name.

https://www.ietf.org/rfc/rfc2388.txt
says

Each field has a name. Within a given form, the names are unique.

So we can't have empty names, if I'm reading the spec right.

Also, I suspect that the multipart parser might just throw an error if there're multiple parts with empty names.

UPD:

Chrome's parser seems to be handling it fine.

UPD2:

Well, kinda fine

----------------------------656399404245038028349435
Content-Disposition: form-data; name=""

my value1
----------------------------656399404245038028349435
Content-Disposition: form-data; name="abc"

my value2
----------------------------656399404245038028349435
Content-Disposition: form-data; name=""

my value3
----------------------------656399404245038028349435--

image

It just ignores the 3rd part when form.get("").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants