-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Customer Center] Add API call to get Customer Center config #3933
base: integration/customer_support_workflow
Are you sure you want to change the base?
[Customer Center] Add API call to get Customer Center config #3933
Conversation
9423df6
to
c350297
Compare
26fb266
to
abb1c50
Compare
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c0a38a1
to
25222e9
Compare
8957234
to
2f36ec7
Compare
25222e9
to
0309db3
Compare
2f36ec7
to
2d41724
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I would probably hold off merging back to main until the feature is ready in case the public API changes (or we can make it internal until everything is ready).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we are missing tests? Not sure if we are doing those in a separate PR though
0309db3
to
9c89313
Compare
ad260d3
to
3dd2fb0
Compare
2858c16
to
8f21718
Compare
3dd2fb0
to
821016e
Compare
4ab05c3
to
5fcbe86
Compare
6572cf1
to
7f655ec
Compare
5fcbe86
to
205ef77
Compare
7f655ec
to
8f8c9fc
Compare
Adds
Purchases.shared.loadCustomerCenter()
that calls a new backend endpoint that returns the customer center configurationThis API call doesn't exist yet and it will change. This PR is the ground work so that we don't have to wait for the backend to add this API and we can already pretend the API is there.