Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): disable snapshot diffs #596

Merged
merged 1 commit into from
Nov 19, 2022
Merged

Conversation

RobertCraigie
Copy link
Owner

@RobertCraigie RobertCraigie commented Nov 19, 2022

Change Summary

This PR disables the creation of diffs for our snapshot tests on the generated client code. This is because it can take a long time to generate this diff in CI and we don't really care what the actual diff is, we just need to know that there is a difference.

tophat/syrupy#581

Checklist

  • Unit tests for the changes exist
  • Tests pass without significant drop in coverage
  • Documentation reflects changes where applicable
  • Test snapshots have been updated if applicable

Agreement

By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Base: 87.03% // Head: 87.01% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (3112616) compared to base (f6b1008).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   87.03%   87.01%   -0.03%     
==========================================
  Files         133      133              
  Lines        6347     6352       +5     
  Branches     1160     1160              
==========================================
+ Hits         5524     5527       +3     
- Misses        779      781       +2     
  Partials       44       44              
Impacted Files Coverage Δ
...ests/test_generation/exhaustive/test_exhaustive.py 96.55% <66.66%> (-3.45%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RobertCraigie RobertCraigie marked this pull request as ready for review November 19, 2022 10:58
@RobertCraigie RobertCraigie merged commit c449825 into main Nov 19, 2022
@RobertCraigie RobertCraigie deleted the fix-snapshot-diffs branch November 19, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant