auto renewal of refresh token, update cfclient #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete cacheEntry when expired
RalfHammer
commented
Oct 7, 2024
uwefreidank
changed the title
RalfHammer
commented
Oct 8, 2024
uwefreidank
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go-cfclient
Caching of CF client instances requires proper renewal of oauth tokens.
Therefore, we update to newer version of go-cfclient (v3.0.0-alpha.6 includes improvements).
However, we update directly to newest version v3.0.0-alpha.9.
Auto renewal of CF refresh token
When we started to cache the cf client, the cached cf refresh token won't be recreated until operator restart.
After around 24 hours (depends on server setting) the refresh token gets expired.
The go-cfclient won't handle this expiration (details cloudfoundry/go-cfclient#170).
Solution: Let's periodically delete the cached cf client in order to renew the refresh token.