Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resorting Instance CR .md #466

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Resorting Instance CR .md #466

wants to merge 2 commits into from

Conversation

danielforsap
Copy link
Collaborator

Pull Request Template

Prerequisites

  • If there is no issue related to your pull request - open one and assign yourself to it. If you're proposing a solution to an already opened issue - simply assign yourself to it.

Motivation

Describe the problem you're trying to solve or the feature you're proposing in addition to a link to the related issue.

Approach

How does this change address the problem?

Pull Request status

  • Initial implementation
  • Refactoring
  • Unit tests
  • Integration tests

Feel free to construct the checklist with whatever items seem most reasonable for your change. You could disassemble the Implementation part to even smaller separate checklist items if you're working on something big for example. But do make the effort to provide a checklist of some sort so that the core team as well as the community can have an idea about the progress of your Pull Request.

Third-party code

If you use third party code with your contribution such as, components, libraries, or snippets make sure to mention that.

Work in Progress label

For as long as development of your Pull Request is still ongoing you MUST label it with a wip label as well as prefix the name of the PR with [WIP].

For example: [WIP] Service brokers API

README.md Outdated

2. Recreate the CR:

a) If you have a YAML definition or manifest for your CR, ensure it includes the exact name, namespace, and (if applicable) cluster ID you retrieved from the SAP BTP service instance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cluster id is not configurable in the CR yaml, it is part of the deployment config.
the cluster id usally does not change (we have a code that ensures that) so i would not put this step, i would mention it only if verification step failed. (if the instance in the cluster does not have the same instance id as the BTP instance verify the cluster id matches (it is part of the context and visibile in the cockpit or btp cli), if it does not match then configure the cluster with the right id...)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kerenlahav pls check the new commit. Thanks

README.md Outdated

- The name of the custom resource.
- The Kubernetes namespace where the CR should reside.
- If applicable, retrieve the cluster ID or context associated with the CR in SAP BTP. This ensures the CR is recreated in the correct environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kerenlahav I assume you are talking about removing the third one.

README.md Outdated
@@ -950,7 +950,37 @@ Do not call this API with the service-operator-access plan credentials.

<b>Attention: **Use this option only for cleanup purposes for a cluster that's no longer available.** Applying it to an active and available cluster may result in unintended resource leftovers in your cluster.</b>

### I can see my service instance in SAP BTP, but not its corresponding custom resource in a cluster. What can I do?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see my service instance in SAP BTP, but not its corresponding custom resource my cluster. How can I restore it in the cluster?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kerenlahav I think Avi wanted a more generally-worded question, but I changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants