Update comments

Sage-Bionetworks-Workflows · Jul 11, 2024 · f1518e5 · f1518e5
1 parent 392bce9
commit f1518e5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/modules/sage-aws-eks/main.tf b/modules/sage-aws-eks/main.tf
@@ -56,8 +56,6 @@ module "eks" {
       most_recent = true
     }
     vpc-cni = {
-      # TODO: ENABLE_POD_ENI=true
-      # https://aws.github.io/aws-eks-best-practices/networking/sgpp/
       most_recent = true
       configuration_values = jsonencode({
         enableNetworkPolicy = "true",
@@ -69,7 +67,9 @@ module "eks" {
         env = {
           ENABLE_POD_ENI                    = "true",
           POD_SECURITY_GROUP_ENFORCING_MODE = "standard",
-          AWS_VPC_K8S_CNI_EXTERNALSNAT      = "true"
+          # TODO: Turn on strict mode when we are ready to enforce it
+          # POD_SECURITY_GROUP_ENFORCING_MODE = "strict",
+          AWS_VPC_K8S_CNI_EXTERNALSNAT = "true"
       } })
     }
   }

diff --git a/modules/sage-aws-k8s-node-autoscaler/main.tf b/modules/sage-aws-k8s-node-autoscaler/main.tf
@@ -74,10 +74,10 @@ module "ocean-aws-k8s" {
   version = "1.2.0"
 
   # Configuration
-  cluster_name                = var.cluster_name
-  region                      = var.region
-  subnet_ids                  = var.private_vpc_subnet_ids
-  worker_instance_profile_arn = aws_iam_instance_profile.profile.arn
+  cluster_name                     = var.cluster_name
+  region                           = var.region
+  subnet_ids                       = var.private_vpc_subnet_ids
+  worker_instance_profile_arn      = aws_iam_instance_profile.profile.arn
   security_groups                  = [var.node_security_group_id]
   is_aggressive_scale_down_enabled = true
   max_scale_down_percentage        = 33