Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger-always on dependency reference #32

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

BryanFauble
Copy link
Contributor

Problem:

  1. See description on spacelift_stack_dependency skips dependent stack run spacelift-io/terraform-provider-spacelift#565

Solution:

  1. Add trigger_always so that even if a value of a variable being passed along did not change, the dependent stack will still run. This is to fix some issues that @BWMac identified early on when we were incrementing a module version in both the modules/* directory, and updating it's usage in deployments/stacks/*. We previously needed to run this in 2 commits, 1st commit was to get the admin stack to run, 2nd commit was to use the new module version in the deployment.

Testing:

  1. Adding this now and will verify the next time we have a module version update to do.

@BryanFauble BryanFauble requested a review from a team as a code owner August 23, 2024 17:40
Copy link

@jaymedina jaymedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we want to add a Jira ticket to revisit this for another solution that's less aggressive? I wonder if this has the potential to get messy if our infra gets more complex and we add more dependent stacks (if that's a possibility)

@BryanFauble
Copy link
Contributor Author

Looks good! Do we want to add a Jira ticket to revisit this for another solution that's less aggressive? I wonder if this has the potential to get messy if our infra gets more complex and we add more dependent stacks (if that's a possibility)

Let's move forward with this see how everything behaves and make a determination afterword. The only messy thing here is that we'll have more stacks running (Which will in turn follow the stacks deployment settings ie: Auto deploy, or wait for manual approval). The only risk of more stacks running more often is potential delays waiting for the change you care about to run.

@BryanFauble BryanFauble merged commit 49b4ff4 into main Aug 26, 2024
3 checks passed
@BryanFauble BryanFauble deleted the add-trigger-always-on-dependency-reference branch August 26, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants